From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 03/13] ARM: bcm2835: add Raspberry Pi model B board
Date: Wed, 1 Aug 2012 09:22:03 -0700 [thread overview]
Message-ID: <20120801162203.GB16076@bill-the-cat> (raw)
In-Reply-To: <20120801161915.GA16076@bill-the-cat>
On Wed, Aug 01, 2012 at 09:19:15AM -0700, Tom Rini wrote:
> On Tue, Jul 31, 2012 at 10:13:33PM -0600, Stephen Warren wrote:
> > The Raspberry Pi model B uses the BCM2835 SoC, has 256MB of RAM, contains
> > an SMSC 9512 USB LAN/Hub chip, and various IO connectors. For more details,
> > see http://www.raspberrypi.org/.
> >
> > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> [snip]
> > +int dram_init(void)
> > +{
> > + gd->ram_size = SZ_256M;
> > +
> > + return 0;
> > +}
>
> You should use get_ram_size(CONFIG_SYS_SDRAM_BASE,
> max-possible-dram-size); I say this as I just found a "oh, so that's
> why mainline reports the right amount of memory and other tree does not"
> bug yesterday. This should also be in the SoC-generic code area (like
> say arch/arm/cpu/arm1176/bcm2835/board.c). Sorry I didn't spot this
> last go-round.
I forgot about the video co-processor change later in the series, so you
can disregard this specific comment. But I have some still applicable
comments I'm going to add to the 0/13 patch now.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120801/542ec027/attachment.pgp>
next prev parent reply other threads:[~2012-08-01 16:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 4:13 [U-Boot] [PATCH V2 00/13] Basic Raspberyr Pi support Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 01/13] README: fix references to config_cmd_default.h Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 02/13] ARM: add basic support for the Broadcom BCM2835 SoC Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 03/13] ARM: bcm2835: add Raspberry Pi model B board Stephen Warren
2012-08-01 16:19 ` Tom Rini
2012-08-01 16:22 ` Tom Rini [this message]
2012-08-01 4:13 ` [U-Boot] [PATCH V2 04/13] ARM: arm1176: enable instruction cache in arch_cpu_init() Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 05/13] ARM: rpi_b: enable CONFIG_ARCH_CPU_INIT for icache Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 06/13] ARM: rpi_b: define CONFIG_MACH_TYPE Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 07/13] ARM: rpi_b: include config_cmd_default.h Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 08/13] ARM: rpi_b: enable booting the Linux kernel Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 09/13] ARM: rpi_b: drop RAM size to 128M Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 10/13] ARM: rpi_b: move stack to top of RAM Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 11/13] ARM: bcm2835: implement reset using watchdog Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 12/13] gpio: bcm2835: Add GPIO driver Stephen Warren
2012-08-01 4:13 ` [U-Boot] [PATCH V2 13/13] rbpi: Add BCM2835 GPIO driver for raspberry pi Stephen Warren
2012-08-01 16:25 ` [U-Boot] [PATCH V2 00/13] Basic Raspberyr Pi support Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801162203.GB16076@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox