From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 1 Aug 2012 19:00:11 -0400 Subject: [U-Boot] [PATCH v3 4/7] dfu: MMC specific routines for DFU operation In-Reply-To: <1343716623-8943-5-git-send-email-l.majewski@samsung.com> References: <1341308291-14663-1-git-send-email-l.majewski@samsung.com> <1343716623-8943-1-git-send-email-l.majewski@samsung.com> <1343716623-8943-5-git-send-email-l.majewski@samsung.com> Message-ID: <201208011900.13973.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 31 July 2012 02:37:00 Lukasz Majewski wrote: > --- /dev/null > +++ b/drivers/dfu/dfu_mmc.c > > +static int mmc_block_op(enum dfu_mmc_op op, struct dfu_entity *dfu, > + void *buf, long *len) > +{ > + ALLOC_CACHE_ALIGN_BUFFER(char, cmd_buf, DFU_CMD_BUF_SIZE); ugh, what ? you're passing this string to run_command so there is no point in aligning it (not to mention the topic of u-boot code internally calling run_command() is seriously wrong. > + memset(cmd_buf, '\0', sizeof(cmd_buf)); > + > + sprintf(cmd_buf, "mmc %s 0x%x %x %x", that memset is pointless. delete it. > +static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, > + void *buf, long *len) > +{ came comments for this func as above > +int dfu_fill_entity_mmc(struct dfu_entity *dfu, char* s) "char *s", not "char* s". please search all your patches for this mistake as it seems to have come up a lot. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: