public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Markus Hubig <mhubig@imko.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards.
Date: Thu, 2 Aug 2012 16:14:37 +0200	[thread overview]
Message-ID: <20120802141437.GA18194@imko.de> (raw)
In-Reply-To: <5018FDBE.1010209@googlemail.com>

On Wed, Aug 01, 2012 at 11:58:22AM +0200, Andreas Bie?mann wrote:
> On 30.07.12 20:01, Markus Hubig wrote:
> >

<snipp>

> > +int board_early_init_f(void)
> > +{
> > +	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> > +
> > +	/* Enable clocks for all PIOs */
> > +	writel((1 << ATMEL_ID_PIOA) | (1 << ATMEL_ID_PIOB) |
> > +		(1 << ATMEL_ID_PIOC), &pmc->pcer);
> 
> you should initialize seriald_hw here to avoid strange characters on
> serial line when switching from at91bootstrap to u-boot.

<snip>

> > +	/* adress of boot parameters */
> > +	gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
> > +
> > +	at91_set_gpio_output(AT91_PIN_PC9, 1);
> > +	at91_set_gpio_output(AT91_PIN_PC5, 1);
> 
> Can you please add some comment why switching these pins?

OK now I now that PC5 switches the red LED on and there since is a
LED framework in u-boot I will use that in a later patch.

PC9 is somewhat strange. If I set it to 0 I don't have a console!

So I tried to put both

| at91_set_gpio_output(AT91_PIN_PC9, 1);
| at91_seriald_hw_init();

into board_early_init_f() to avoid the strange characters at boot time,
but again no console output ...

Further tests showed that It seems that I can't use at91_set_gpio_output()
inside board_early_init_f(). Switching on the red LED with PC5 also do not
work in board_early_init_f() ...

Any ideas?

Cheers, Markus

  parent reply	other threads:[~2012-08-02 14:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 18:01 [U-Boot] [PATCH] at91: Add support for taskit AT91SAM9G20 boards Markus Hubig
2012-08-01  9:58 ` Andreas Bießmann
2012-08-01 19:28   ` Markus Hubig
2012-08-01 20:21     ` Andreas Bießmann
2012-08-02 13:28       ` Markus Hubig
2012-08-02 13:59         ` [U-Boot] [PATCHv3] " Markus Hubig
2012-08-03 12:05         ` [U-Boot] [PATCH] " Markus Hubig
2012-08-06 12:18           ` Andreas Bießmann
2012-08-01 19:49   ` [U-Boot] [PATCH] Enable the EMAC clock in at91_macb_hw_init() Markus Hubig
2012-08-07 22:14     ` Andreas Bießmann
2012-08-01 19:57   ` [U-Boot] [PATCHv2] at91: Add support for taskit AT91SAM9G20 boards Markus Hubig
2012-08-01 20:59     ` Andreas Bießmann
2012-08-02 10:46       ` Markus Hubig
2012-08-06 12:22         ` Andreas Bießmann
2012-08-02 14:14   ` Markus Hubig [this message]
2012-08-06 12:49     ` [U-Boot] [PATCH] " Andreas Bießmann
2012-08-06 16:03       ` Markus Hubig
2012-08-06  9:05 ` Markus Hubig
2012-08-06  9:13   ` Markus Hubig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120802141437.GA18194@imko.de \
    --to=mhubig@imko.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox