public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE
Date: Mon, 06 Aug 2012 11:07:41 +0200	[thread overview]
Message-ID: <20120806110741.2d886b43@amdc308.digital.local> (raw)
In-Reply-To: <20120804183545.3c3ea704@gmail.com>

Dear David du Colombier,

> > This fix prevents env_import() CRC to fail when CONFIG_ENV_SIZE
> > is not equal to 4096 bytes
> > It also prevents mtd->read and mtd->write to be incomplete when
> > the environment is larger than 4096 bytes.
> > 
> > Signed-off-by: David du Colombier <0intro@gmail.com>
> > ---
> >  common/env_onenand.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/common/env_onenand.c b/common/env_onenand.c
> > index 7197ab6..da35071 100644
> > --- a/common/env_onenand.c
> > +++ b/common/env_onenand.c
> > @@ -39,7 +39,7 @@
> >  
> >  char *env_name_spec = "OneNAND";
> >  
> > -#define ONENAND_MAX_ENV_SIZE	4096
> > +#define ONENAND_MAX_ENV_SIZE	CONFIG_ENV_SIZE
> >  #define ONENAND_ENV_SIZE(mtd)	(ONENAND_MAX_ENV_SIZE -
> > ENV_HEADER_SIZE) 
> >  DECLARE_GLOBAL_DATA_PTR;
> 
> Could you please take a look? It fixes environment
> saving and restoring on IGEPv2.
> 
> Thanks.
> 

Tested-by: Lukasz Majewski <l.majewski@samsung.com>

Test HW: S5PC110 GONI

Applied to u-boot-onenand repository,


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group

      reply	other threads:[~2012-08-06  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 21:24 [U-Boot] [PATCH] env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE David du Colombier
2012-08-04 16:35 ` David du Colombier
2012-08-06  9:07   ` Lukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120806110741.2d886b43@amdc308.digital.local \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox