From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [QUESTION] "ethaddr" env. var. vs. dev->enetaddr
Date: Mon, 6 Aug 2012 19:40:41 -0400 [thread overview]
Message-ID: <201208061940.42635.vapier@gentoo.org> (raw)
In-Reply-To: <CANr=Z=bVQpseJPMXHOSxC3asQjBs6sjBD=uoiKfPo9-r-+Y3Bw@mail.gmail.com>
On Monday 06 August 2012 18:45:58 Joe Hershberger wrote:
> On Mon, Aug 6, 2012 at 2:02 PM, Beno?t Th?baudeau wrote:
> > There's a lot of stuff in U-Boot relying on ethaddr being set, e.g. the
> > bdinfo command, or the linklocal command because of seed_mac. If ethaddr
> > is not set, bdinfo will report exactly that, but linklocal will wait
> > indefinitely without displaying anything.
>
> This sounds like a problem to be fixed one way or another.
there was a patch floating around for setting up ethaddr env var automatically
in the net core during init if it wasn't already set
> > Hence, shouldn't the users of ethaddr rather use dev->enetaddr, or is
> > ethaddr really supposed to be required (bug or feature)?
>
> Because of the logic that prevents dev->enetaddr set from hardware to
> override ethaddr (since ethaddr should always be the source of the MAC
> in all but exceptional cases), it seems to me that using ethaddr is
> correct. Perhaps in the case of bdinfo, it could explicitly say that
> ethaddr is not set, and if dev->enetaddr is in use, it could also
> print that.
no, nothing outside of the net layer should ever touch dev->enetaddr. this is
clearly documented in doc/README.enetaddr.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120806/2d5f8eed/attachment.pgp>
next prev parent reply other threads:[~2012-08-06 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <261180882.2030378.1344278963347.JavaMail.root@advansee.com>
2012-08-06 19:02 ` [U-Boot] [QUESTION] "ethaddr" env. var. vs. dev->enetaddr Benoît Thébaudeau
2012-08-06 22:45 ` Joe Hershberger
2012-08-06 23:40 ` Mike Frysinger [this message]
2012-08-07 0:49 ` Fabio Estevam
2012-08-07 2:39 ` Rob Herring
2012-08-07 0:48 ` Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208061940.42635.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox