[U-Boot] [PATCH] mkconfig: fix failure on boards that don't define soc

[U-Boot] [PATCH] mkconfig: fix failure on boards that don't define soc

[Allen Martin]

Fix a configure failure on boards that don't define soc.  The exit
status of the subshell was propogating up and causing mkconfig to
fail.  Add an explicit exit 0 to the subshell to fix this.

Signed-off-by: Allen Martin <amartin@nvidia.com>
---
 mkconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mkconfig b/mkconfig
index 07031c6..d3363c6 100755
--- a/mkconfig
+++ b/mkconfig
@@ -144,7 +144,8 @@ fi
     echo "BOARD  = ${board}"
 
     [ "${vendor}" ] && echo "VENDOR = ${vendor}"
-    [ "${soc}"    ] && echo "SOC    = ${soc}" ) > config.mk
+    [ "${soc}"    ] && echo "SOC    = ${soc}"
+    exit 0 ) > config.mk
 
 # Assign board directory to BOARDIR variable
 if [ -z "${vendor}" ] ; then
-- 
1.7.9.5

[U-Boot] [PATCH] mkconfig: fix failure on boards that don't define soc

[Allen Martin]

On Mon, Aug 06, 2012 at 05:04:28PM -0700, Allen Martin wrote:
> Fix a configure failure on boards that don't define soc.  The exit
> status of the subshell was propogating up and causing mkconfig to
> fail.  Add an explicit exit 0 to the subshell to fix this.
> 
> Signed-off-by: Allen Martin <amartin@nvidia.com>

I ran a full MAKEALL -a arm on a system where I reproduced the failure
on jornada previously and it ran clean.


-Allen
-- 
nvpublic

[U-Boot] [PATCH] mkconfig: fix failure on boards that don't define soc

[Mike Frysinger]

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120806/29356931/attachment.pgp>

[U-Boot] [PATCH] mkconfig: fix failure on boards that don't define soc

[Albert ARIBAUD]

Hi Allen,

On Mon, 6 Aug 2012 17:07:25 -0700, Allen Martin <amartin@nvidia.com> wrote:
> On Mon, Aug 06, 2012 at 05:04:28PM -0700, Allen Martin wrote:
> > Fix a configure failure on boards that don't define soc.  The exit
> > status of the subshell was propogating up and causing mkconfig to
> > fail.  Add an explicit exit 0 to the subshell to fix this.
> > 
> > Signed-off-by: Allen Martin <amartin@nvidia.com>
> 
> I ran a full MAKEALL -a arm on a system where I reproduced the failure
> on jornada previously and it ran clean.
> 
> 
> -Allen

Sorry, Allen, missed this. I'd rather have this fix directly corrected in the
original tegra/master commit so that bisecting remains feasible around this.
 
Amicalement,
-- 
Albert.