public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra20: add back USE_PRIVATE_LIBGCC
Date: Tue, 07 Aug 2012 20:36:43 +0200	[thread overview]
Message-ID: <20120807183643.47AF6204016@gemini.denx.de> (raw)
In-Reply-To: <1344298788-7059-1-git-send-email-dev@lynxeye.de>

Dear Lucas Stach,

In message <1344298788-7059-1-git-send-email-dev@lynxeye.de> you wrote:
> As discussed here [http://patchwork.ozlabs.org/patch/158202/] we want to
> use USE_PRIVATE_LIBGCC still.
> 
> However commit 5286f1ce dropped it regardless. Adding this back fixes a
> hang while handing over from SPL to U-Boot on Colibri T20.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> CC: Stephen Warren <swarren@wwwdotorg.org>
> CC: Tom Warren <TWarren@nvidia.com>
> ---
>  arch/arm/cpu/armv7/tegra20/config.mk | 2 ++
>  1 Datei ge?ndert, 2 Zeilen hinzugef?gt(+)
> 
> diff --git a/arch/arm/cpu/armv7/tegra20/config.mk b/arch/arm/cpu/armv7/tegra20/config.mk
> index 6432e75..e666f6b 100644
> --- a/arch/arm/cpu/armv7/tegra20/config.mk
> +++ b/arch/arm/cpu/armv7/tegra20/config.mk
> @@ -23,4 +23,6 @@
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>  # MA 02111-1307 USA
>  #
> +USE_PRIVATE_LIBGCC = yes

NAK.

USE_PRIVATE_LIBGCC is a workaround for broken tool chains only.  It
must never be automatically set for any configuration.

If you know of tool chains that require this, then complain there and
have the bugs fixed with hteir upstream.

Yes, I know this may be painful to you, and it _shall_ be painful, so
that you finally take some action to have the tool chains fixed that
need so.

I will not accept anything like this in mainline.  Sorry.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Status quo. Latin for "the mess we're in."

      parent reply	other threads:[~2012-08-07 18:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  0:19 [U-Boot] [PATCH] tegra20: add back USE_PRIVATE_LIBGCC Lucas Stach
2012-08-07 17:00 ` Stephen Warren
2012-08-07 17:09   ` Lucas Stach
2012-08-07 17:43     ` Allen Martin
2012-08-07 17:53       ` Lucas Stach
2012-08-07 20:11         ` Allen Martin
2012-08-07 22:28         ` Allen Martin
2012-08-07 22:42           ` Lucas Stach
2012-08-07 23:34             ` Allen Martin
2012-08-07 18:36 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807183643.47AF6204016@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox