[U-Boot] [PATCH v2 2/5] ehci-hcd: Boost transfer speed

Marek Vasut
2012-07-27T14:30:35Z

Dear Beno?t Th?baudeau,

> Dear Marek,
>
> On Fri, Jul 27, 2012 at 04:07:01 PM, Marek Vasut wrote:
> > > + qtd = memalign(USB_DMA_MINALIGN, qtd_count * sizeof(struct qTD));
> > > + if (qtd == NULL) {
> > > + printf("unable to allocate TDs\n");
> > > + return -1;
> > > + }
> > > +
> > >
> > > memset(qh, 0, sizeof(struct QH));
> > >
> > > - memset(qtd, 0, 3 * sizeof(*qtd));
> > > + memset(qtd, 0, qtd_count * sizeof(*qtd));
> > >
> > > toggle = usb_gettoggle(dev, usb_pipeendpoint(pipe),
> > > usb_pipeout(pipe));
> >
> > [...]
> >
> > I'm cool with the rest, I'll think about the calculation a bit
> > though, since I'm
> > not certain about it right away and let you know. Will you be
> > submitting the
> > series again or shall I just merge 3/5 and 4/5, apply this one and be
> > done with
> > it?
>
> I'll resubmit the whole series. I'll first answer Stefan in this thread
> when possible.

Please do, and see how Jim is with the timeout patch please.

> Regards,
> Beno?t

Best regards,
Marek Vasut