From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 10 Aug 2012 21:34:14 +0200
Subject: [U-Boot] [PATCH v4 4/7] usb_storage: Remove EHCI constraints
In-Reply-To: <608964076.2281855.1344624202187.JavaMail.root@advansee.com>
References: <608964076.2281855.1344624202187.JavaMail.root@advansee.com>
Message-ID: <201208102134.14608.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Beno?t Th?baudeau,

> Hi Ilya,
> 
> On Fri, Aug 10, 2012 at 8:34:14 PM, Ilya Yanok wrote:
> > Hi Benoit,
> > 
> > On Fri, Aug 10, 2012 at 8:23 PM, Beno?t Th?baudeau <
> > 
> > benoit.thebaudeau at advansee.com > wrote:
> > > diff --git u-boot-usb-4f8254e.orig/common/usb_storage.c
> > > u-boot-usb-4f8254e/common/usb_storage.c
> > > 
> > > index 0cd6399..822bd64 100644
> > > 
> > > --- u-boot-usb-4f8254e.orig/common/usb_storage.c
> > > 
> > > +++ u-boot-usb-4f8254e/common/usb_storage.c
> > > 
> > > @@ -157,12 +157,13 @@ struct us_data {
> > > 
> > > 
> > > #ifdef CONFIG_USB_EHCI
> > > 
> > > /*
> > > 
> > > - * The U-Boot EHCI driver cannot handle more than 5 page aligned
> > > buffers
> > > 
> > > - * of 4096 bytes in a transfer without running itself out of
> > > qt_buffers
> > > 
> > > + * The U-Boot EHCI driver can handle any transfer length as long
> > > as
> > > there is
> > > 
> > > + * enough free heap space left, but the SCSI READ(10) and
> > > WRITE(10)
> > > commands are
> > > 
> > > + * limited to 65535 bytes.
> > 
> > bytes?
> > 
> > > */
> > > 
> > > -#define USB_MAX_XFER_BLK(start, blksz) (((4096 * 5) - (start %
> > > 4096)) / blksz)
> > > 
> > > +#define USB_MAX_XFER_BLK 65535
> > 
> > But here you limit it to 65535 _blocks_, right? One of the two should
> > be wrong ;)
> 
> Argh, it was a typo in the comment. Thanks for catching this. I meant
> "blocks" of course. Marek, can you fix this comment on-the-fly when
> applying?

Roger, will do!

> Best regards,
> Beno?t

Best regards,
Marek Vasut