From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 11 Aug 2012 13:48:33 -0400 Subject: [U-Boot] [PATCH 5/5] Add env var giving the board revision In-Reply-To: <2028294275.2280404.1344620768178.JavaMail.root@advansee.com> References: <2028294275.2280404.1344620768178.JavaMail.root@advansee.com> Message-ID: <201208111348.33937.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 10 August 2012 13:46:08 Beno?t Th?baudeau wrote: > The board revision can be a useful env var, like its serial number. unless i missed something, there is no standard "rev" variable today, which means this change can easily break anyone who happens to already be using a variable named "rev". i also don't see value here in hardcoding another variable that: - no one is setting - is way too generic (rev of *what* ? cpu ? board ? u-boot ? something else ?) - adds nothing on top of the existing "serial#" so NAK from me -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: