From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 12 Aug 2012 02:07:30 +0200 Subject: [U-Boot] [PATCH 1/1] USB: Fix strict aliasing in ohci-hcd In-Reply-To: <1344721749-25644-1-git-send-email-troy.kisky@boundarydevices.com> References: <1344721749-25644-1-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <201208120207.31009.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Troy Kisky, > commit 5f6aa03fda2a0a79940765865c1e4266be8a75f8 > USB: Fix complaints about strict aliasing in OHCI-HCD > > tried to fix this, but gcc4.4 still complains. So, this > patch basically reverts the above and does a simpler fix. > > also, the above commit incorrectly changed > /* corresponds to data_buf[4-7] */ > datab [1] = 0; > to > > /* corresponds to databuf.u8[4-7] */ > databuf.u8[1] = 0; > > This patch also fixes that. [...] AGAIN?! :-C If I were to run git log on that file, I'd get like five such "fixes" :-( I'll review this properly tomorrow, this will be certainly a very pleasant reviewing time ;-) Best regards, Marek Vasut