public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtest: Disable dcache during test
Date: Tue, 14 Aug 2012 08:27:10 +0200	[thread overview]
Message-ID: <20120814082710.4f867663@aari01-12> (raw)
In-Reply-To: <201208111615.17567.vapier@gentoo.org>

Hi Mike,

On Sat, 11 Aug 2012 16:15:16 -0400, Mike Frysinger <vapier@gentoo.org>
wrote:
> On Saturday 11 August 2012 16:05:36 Beno?t Th?baudeau wrote:
> > On 08/11/2012 21:47, Andrew Dyer wrote:
> > > I agree with Mike, use the current dcache settings. U-boot has
> > > always assumed the user knew what they were doing.
> > > If you want to print a small message with the dcache setting that
> > > makes sense to me, but no big warning.
> > 
> > Then, something like the following at runtime in the first lines
> > printed my mtest?
> > 
> > dcache state: on
> 
> i'd be fine with that.  something like below (if you want to test &
> post, that'd be good).
> -mike

I'd disagree with this solution; one can easily overlook casual test
messages like these. To me it is better that the person doing mtest not
trust the cache state at all and check / set it.

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2012-08-14  6:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CANYL96C2=fYHoTAp0SQird-Yz1W2JPq22U=3q4ZFKgwomXxODA@mail.gmail.com>
2012-08-11 20:05 ` [U-Boot] [PATCH] mtest: Disable dcache during test Benoît Thébaudeau
2012-08-11 20:15   ` Mike Frysinger
2012-08-11 20:25     ` Benoît Thébaudeau
2012-08-13 10:59       ` [U-Boot] [PATCH] mtest: Print dcache state Benoît Thébaudeau
2012-10-03 22:05         ` [U-Boot] " Tom Rini
2012-10-04 11:03           ` Albert ARIBAUD
2012-10-04 11:13             ` Benoît Thébaudeau
2012-10-04 14:15               ` Tom Rini
2012-08-14  6:27     ` Albert ARIBAUD [this message]
2012-08-10 19:16 [U-Boot] [PATCH] mtest: Disable dcache during test Benoît Thébaudeau
2012-08-11  3:18 ` Mike Frysinger
2012-08-11 14:17   ` Benoît Thébaudeau
2012-08-11 17:50     ` Mike Frysinger
2012-08-11 18:49       ` Benoît Thébaudeau
2012-09-02 16:30     ` Wolfgang Denk
2012-09-03 14:25       ` Benoît Thébaudeau
2012-09-03 16:50         ` Albert ARIBAUD
2012-09-03 21:14           ` Benoît Thébaudeau
2012-09-03 23:30             ` Graeme Russ
2012-09-04  6:41               ` Wolfgang Denk
2012-09-04  6:43                 ` Graeme Russ
2012-09-04  7:23         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120814082710.4f867663@aari01-12 \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox