[U-Boot] [PATCH] fix IDE_BUS(dev) macro

Albert ARIBAUD
2012-04-19T06:38:19Z

Hi Dave,

Le 18/04/2012 23:37, David Purdy a ?crit :
> On Tue, Apr 17, 2012 at 2:06 PM, Luka Perkov<uboot@lukaperkov.net> wrote:
>> IDE_BUS assumes that each bus has two devices and thus returns the first
>> bus even when the second one should be probed.
>>
>> Signed-off-by: Simon Baatz<gmbnomis@gmail.com>
>> Tested-by: Luka Perkov<uboot@lukaperkov.net>
>> ---
>>
>> Simon discovered this while adding support for new board IB NAS6210.
>>
>> More info can be found here:
>>
>> http://lists.denx.de/pipermail/u-boot/2012-April/122525.html
>>
>> When this is commited I will do a coding style cleanup. There are tabs
>> after few "#define" parts in include/ide.h.
>>
>> include/ide.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/ide.h b/include/ide.h
>> index 8ecc9dd..385e909 100644
>> --- a/include/ide.h
>> +++ b/include/ide.h
>> @@ -24,7 +24,7 @@
>> #ifndef _IDE_H
>
> Simon, Luka, Prafulla, etal,
>
> I've tested this out on the Seagate GoFlex Net (Kirkwood) device,
> which also has dual SATA ports, and it resolved the long-standing (and
> irritating) bug/unwanted-feature that required us to boot from _only_
> the right side port.
>
> I would guess that other Kirkwood dual-SATA-port boxes would be
> happier because of this, as well.
>
> Nice catch, Simon.

Not my main area of expertise here, but I am not sure how this plays on
Marvell non-kirkwood platforms (e.g., orion5x).

ISTR it is not the first time we deal with the whole IDE number of bus /
number of ports [ / useable ports ] issue, and we may be running in
circles here, fixing one platform and breaking another.

I'll try this on EDMiniV2 in the coming days, and let people know the
results in this thread.

> regards,
>
> Dave

Amicalement,
--
Albert.