public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7
Date: Wed, 15 Aug 2012 11:14:00 -0700	[thread overview]
Message-ID: <20120815181400.GB4086@nvidia.com> (raw)
In-Reply-To: <1344528116-13967-1-git-send-email-trini@ti.com>

On Thu, Aug 09, 2012 at 09:01:54AM -0700, Tom Rini wrote:
> Hey all,
> 
> As Allen Martin noted, on tegra platforms a bug is exposed when using
> certain toolchains that currently calls to lowlevel_init must be calls
> to another assembly function as the stack is not explicitly setup /
> saved and thus register corruption can occur.  Over in TI-land Aneesh V
> wrote a lowlevel_init that sets up the stack and calls s_init which is a
> C function that does what lowlevel_init does on other platforms.  The
> code is generic to at least v7, so this series moves it to
> arch/arm/cpu/armv7.  The initial version of the code made use of
> LOW_LEVEL_SRAM_STACK as the stack to be setup.  This define is
> essentially another name for CONFIG_SYS_INIT_SP_ADDR without taking
> GENERATED_GBL_DATA_SIZE into consideration.  So we switch to that
> instead.  Finally, Wolfgang question me as to if the stack really only
> needed the alignment that we had been giving it.  To be safe, I grabbed
> the alignmnet that we do when setting up the initial stack for real and
> placed it into lowlevel_init as well.
> 
> Tested on AM335x GP EVM and OMAP4 Pandaboard ES2.
> 

Converted tegra to use the new lowlevel_init wrapper and tested on
seaboard.  Verified it works with the previously failing CodeSourcery
2011.09-70 toolchain.

I'll respin my tegra SPL series to depend on these.

-Allen


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

      parent reply	other threads:[~2012-08-15 18:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 16:01 [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7 Tom Rini
2012-08-09 16:01 ` [U-Boot] [PATCH 1/2] omap4/5/am33xx: Make lowlevel_init available to all armv7 platforms Tom Rini
2012-08-13  6:28   ` R, Sricharan
2012-08-13 14:55     ` Tom Rini
2012-08-15 18:16   ` Allen Martin
2012-08-09 16:01 ` [U-Boot] [PATCH 2/2] armv7: Make lowlevel_init.S's lowlevel_init do ABI compatible stack Tom Rini
2012-08-15 18:16   ` Allen Martin
2012-08-13  7:48 ` [U-Boot] [PATCH 0/2]: arm: Provide lowlevel_init C function wrapper for v7 Stefano Babic
2012-08-13 14:57   ` Tom Rini
2012-08-15 18:14 ` Allen Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815181400.GB4086@nvidia.com \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox