From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers
Date: Thu, 16 Aug 2012 22:19:47 +0200 [thread overview]
Message-ID: <201208162219.47962.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAKGA1bnOV4xRwx2bHhXUzj-bNOcasDvE9JiJFM+HU8ZQm89HsA@mail.gmail.com>
Dear Matt Sealey,
> I'm gonna NACK
You can't, only the custodians can ... you can only disagree and provide your
opinion, which you did ;-)
> this because most of these pin settings are actually
> the POR defaults anyway (UART1 is
> the example I can easily pick out).
>
> .. unless someone's setting them up wrong between warn reboots
Which in turn might cause trouble during reboots, so it's better to configure
them back properly.
> or
> changing a UART into something else
> later in boot.. which is unfathomable.. we don't need to even touch
> the iomux controller to get a working UART
> on MX51, Efika MX or anything.
You don't ... lucky you.
> Why bother touching them?
To avoid cases where broken kernel can't reboot or even cause hardware damage.
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-16 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 15:46 [U-Boot] [PATCH 1/2] mx5: Add default pin initializers Benoît Thébaudeau
2012-08-14 15:47 ` [U-Boot] [PATCH 2/2] mx5: Use " Benoît Thébaudeau
2012-08-15 14:37 ` Benoît Thébaudeau
2012-08-16 19:46 ` Matt Sealey
2012-08-16 20:09 ` Benoît Thébaudeau
2012-08-16 21:25 ` Matt Sealey
2012-08-16 22:51 ` Benoît Thébaudeau
2012-08-17 18:53 ` Matt Sealey
2012-08-17 19:26 ` Benoît Thébaudeau
2012-08-17 21:08 ` Stefano Babic
2012-08-16 20:19 ` Marek Vasut [this message]
2012-08-17 19:10 ` [U-Boot] [PATCH 1/2] mx5: Add " Matt Sealey
2012-08-17 19:40 ` Benoît Thébaudeau
2012-08-17 20:25 ` Stefano Babic
2012-08-17 20:38 ` Matt Sealey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208162219.47962.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox