From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 17 Aug 2012 15:34:44 -0400 Subject: [U-Boot] [[Patch V2] mips: 04/16] add cpu/mips64/cpu.c In-Reply-To: <1345217476-32034-5-git-send-email-etou.zh@gmail.com> References: <1345217476-32034-1-git-send-email-etou.zh@gmail.com> <1345217476-32034-5-git-send-email-etou.zh@gmail.com> Message-ID: <201208171534.45260.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 17 August 2012 11:30:47 Zhizhou Zhang wrote: > --- /dev/null > +++ b/arch/mips/cpu/mips64/cpu.c > > +void __attribute__((weak)) _machine_restart(void) > +{ > +} change to __weak (include linux/compiler.h if you need to). > +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +{ > + _machine_restart(); > + > + fprintf(stderr, "*** reset failed ***\n"); > + return 0; > +} this function should never return. add a __noreturn to machine_restart(). > +void cache_probe() (void) -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: