From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add a memory get command
Date: Fri, 17 Aug 2012 19:47:49 -0400 [thread overview]
Message-ID: <201208171947.50854.vapier@gentoo.org> (raw)
In-Reply-To: <1345237121-20594-1-git-send-email-joe.hershberger@ni.com>
On Friday 17 August 2012 16:58:41 Joe Hershberger wrote:
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
>
> +#ifdef CONFIG_CMD_MEM_GET
not the greatest name ...
> +int do_mem_mg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static
> + size = cmd_get_data_size(argv[0], 4);
> + if (size < 0)
> + return 1;
> +
> + var = argv[1];
> +
> + addr = simple_strtoul(argv[2], NULL, 16);
> + addr += base_address;
> +
> + if (size == 4) {
> + uint32_t value = readl(addr);
why use io.h commands ? we don't use it with any of the other mem commands.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120817/3ed5d089/attachment.pgp>
next prev parent reply other threads:[~2012-08-17 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 20:58 [U-Boot] [PATCH] Add a memory get command Joe Hershberger
2012-08-17 23:47 ` Mike Frysinger [this message]
2012-09-02 19:10 ` Wolfgang Denk
[not found] ` <OFBA608614.0C8902BC-ON86257A6F.0051AAED-86257A6F.005233E4@ni.com>
2012-09-04 22:00 ` Wolfgang Denk
2012-11-02 2:21 ` [U-Boot] [PATCH v2] Add a simple load option to setexpr Joe Hershberger
2012-12-19 23:00 ` [U-Boot] [U-Boot,v2] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208171947.50854.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox