[U-Boot] patman feature request

[U-Boot] patman feature request

[Tom Rini]

Hey,

It looks like today was the day that Joe and I both decided to give
patman a whirl.  On IRC we both hit the same annoyance of commits like:
"Cosmetic: Something" causing patman to look for a maintainer for
cosmetic and failing fatally.  Could we please make maintainer alias not
found a warning and not a fatal error (so the human can go "oh, that's
not a real area, that's fine" ?  My ~/.patman is almost more fixups than
real aliases.

-- 
Tom

[U-Boot] patman feature request

[Otavio Salvador]

On Fri, Aug 17, 2012 at 5:01 PM, Tom Rini <trini@ti.com> wrote:
> It looks like today was the day that Joe and I both decided to give
> patman a whirl.  On IRC we both hit the same annoyance of commits like:
> "Cosmetic: Something" causing patman to look for a maintainer for
> cosmetic and failing fatally.  Could we please make maintainer alias not
> found a warning and not a fatal error (so the human can go "oh, that's
> not a real area, that's fine" ?  My ~/.patman is almost more fixups than
> real aliases.

I agree; I have also sent two minor fixes to patman and I've been
putting fixups on my .patman to make it run and it does seem it would
work better if it was an warn.

Another idea is to have a wildcard that matches as a fallback.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[U-Boot] patman feature request

[Simon Glass]

Hi,

On Fri, Aug 17, 2012 at 1:14 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, Aug 17, 2012 at 5:01 PM, Tom Rini <trini@ti.com> wrote:
>> It looks like today was the day that Joe and I both decided to give
>> patman a whirl.  On IRC we both hit the same annoyance of commits like:
>> "Cosmetic: Something" causing patman to look for a maintainer for
>> cosmetic and failing fatally.  Could we please make maintainer alias not
>> found a warning and not a fatal error (so the human can go "oh, that's
>> not a real area, that's fine" ?  My ~/.patman is almost more fixups than
>> real aliases.
>
> I agree; I have also sent two minor fixes to patman and I've been
> putting fixups on my .patman to make it run and it does seem it would
> work better if it was an warn.

Yes I like the idea of a warning instead of an error. It annoys me too
sometimes, although I do use it as a check against adding a tag that
no one has heard of.

>
> Another idea is to have a wildcard that matches as a fallback.
>

I suppose wildcards matches might be useful - could be overkill though.

Regards,
Simon

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[U-Boot] patman feature request

[Otavio Salvador]

On Fri, Aug 17, 2012 at 6:35 PM, Simon Glass <sjg@chromium.org> wrote:
> On Fri, Aug 17, 2012 at 1:14 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Fri, Aug 17, 2012 at 5:01 PM, Tom Rini <trini@ti.com> wrote:
>>> It looks like today was the day that Joe and I both decided to give
>>> patman a whirl.  On IRC we both hit the same annoyance of commits like:
>>> "Cosmetic: Something" causing patman to look for a maintainer for
>>> cosmetic and failing fatally.  Could we please make maintainer alias not
>>> found a warning and not a fatal error (so the human can go "oh, that's
>>> not a real area, that's fine" ?  My ~/.patman is almost more fixups than
>>> real aliases.
>>
>> I agree; I have also sent two minor fixes to patman and I've been
>> putting fixups on my .patman to make it run and it does seem it would
>> work better if it was an warn.
>
> Yes I like the idea of a warning instead of an error. It annoys me too
> sometimes, although I do use it as a check against adding a tag that
> no one has heard of.
>
>> Another idea is to have a wildcard that matches as a fallback.
>
> I suppose wildcards matches might be useful - could be overkill though.

Maybe the .patman might support a regexp for the tag; this way we can
have things like:

mx[s5]: ...

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br