[U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD

Matt Sealey
2012-08-18T21:11:04Z

On Sat, Aug 18, 2012 at 10:34 AM, Stefano Babic <sbabic@denx.de> wrote:
> On 17/08/2012 20:19, Matt Sealey wrote:
>> The i.MX Boot ROM lets us set up certain registers before U-Boot even gets
>> executed. Rather than setting up DDR, putting U-Boot in place, and getting
>> into pre-relocation init to set up DDR again, just do it once in the correct
>> place. This also solves an issue where the Smarttop DDR pad settings were
>> being applied on Smartbook.
>>
>> While we're at it, configure PCBID0,1,2 and the LED GPIO since we've still
>> got room in the DCD to do so.
>>
>> Signed-off-by: Matt Sealey <matt@genesi-usa.com>
>> ---
>
> Hi Matt,
>
>> diff --git a/board/genesi/mx51_efikamx/imximage_mx.cfg b/board/genesi/mx51_efikamx/imximage_mx.cfg
>> index 6fe0ff9..ac9aa9a 100644
>> --- a/board/genesi/mx51_efikamx/imximage_mx.cfg
>> +++ b/board/genesi/mx51_efikamx/imximage_mx.cfg
>> @@ -1,7 +1,7 @@
>> #
>> +# Copyright (C) 2009 Pegatron Corporation
> ^---
>
> Was this added for mistake ? I think you should add only yours.

The drive strength settings came from Pegatron a long, long time ago
(2009 :) and our old config and the function is copyrighted to them.
Just because Marek took them out and recopyrighted the file I derived
them from in this case doesn't mean they lost their copyright..

> I join Marek, it is quite difficult to review it and understand which
> was changed. It looks like a new file..

It's just because I moved the comments to the end of the line, so it's
blocking it up.

Sometimes it's nicer if it's

-this line
+that line
-this line
+that line

.. but that's not how git does it when the change is more than a few
characters and multiple lines changed.. I can submit it differently
but I can't change the way it's producing the diff.

--
Matt Sealey <matt@genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.