[U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD

Matt Sealey
2012-08-17T22:05:51Z

On Fri, Aug 17, 2012 at 4:03 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Matt Sealey,
>
>> The i.MX Boot ROM lets us set up certain registers before U-Boot even gets
>> executed. Rather than setting up DDR, putting U-Boot in place, and getting
>> into pre-relocation init to set up DDR again, just do it once in the
>> correct place. This also solves an issue where the Smarttop DDR pad
>> settings were being applied on Smartbook.
>>
>> While we're at it, configure PCBID0,1,2 and the LED GPIO since we've still
>> got room in the DCD to do so.
>
> [...]
>
>> diff --git a/board/genesi/mx51_efikamx/imximage_mx.cfg
>> b/board/genesi/mx51_efikamx/imximage_mx.cfg index 6fe0ff9..ac9aa9a 100644
>> --- a/board/genesi/mx51_efikamx/imximage_mx.cfg
>> +++ b/board/genesi/mx51_efikamx/imximage_mx.cfg
>> @@ -1,7 +1,7 @@
>> #
>> +# Copyright (C) 2009 Pegatron Corporation
>> # Copyright (C) 2010 Marek Vasut <marek.vasut@gmail.com>
>> -#
>> -# BASED ON: imx51evk
>
> Adding and removing these at will won't work I'm afraid.
>
>> +# Copyright (C) 2009-2012 Genesi USA, Inc.
>> #
>> # (C) Copyright 2009
>> # Stefano Babic DENX Software Engineering sbabic at denx.de.
>> @@ -43,48 +43,44 @@ BOOT_FROM spi
>> # Address absolute address of the register
>> # value value to be stored in the register
>
> So what is the actual change in the file? You replaced it with different file,
> which makes it hard to review particular changes made.

Uhh no I edited each line manually and moved the comments to make it
more readable. The actual changes is I reviewed the drive strength set
function in efikamx.c and moved all the settings (minus any
erroneously set bits and reproduced settings) into the DATA lines
where necessary.

It's the same file but git doesn't do line-by-line diffs very well, it
just seems to batch things into sections. I agree though I broke the
copyright stuff, I got forced to use vim for about 10 minutes and I
may have been a little heavy-handed :)

--
Matt