[U-Boot] [PATCH 2/4] efikamx: remove drive strength hack from early_init_f and move it to the DCD

stefano babic
2012-08-18T22:39:35Z

Am 18/08/2012 23:11, schrieb Matt Sealey:

>>> @@ -1,7 +1,7 @@
>>> #
>>> +# Copyright (C) 2009 Pegatron Corporation
>> ^---
>>
>> Was this added for mistake ? I think you should add only yours.
>
> The drive strength settings came from Pegatron a long, long time ago
> (2009 :) and our old config and the function is copyrighted to them.
> Just because Marek took them out and recopyrighted the file I derived
> them from in this case doesn't mean they lost their copyright..

Ok, explained - then it is a fixed for a missing copyright.
>
>> I join Marek, it is quite difficult to review it and understand which
>> was changed. It looks like a new file..
>
> It's just because I moved the comments to the end of the line, so it's
> blocking it up.
>
> Sometimes it's nicer if it's
>
> -this line
> +that line
> -this line
> +that line
>
> .. but that's not how git does it when the change is more than a few
> characters and multiple lines changed.. I can submit it differently
> but I can't change the way it's producing the diff.

In principle I have not a problem with it - you are the best tester for
the DCD table, and you report it is well tested for your board. It is
customized for your board and it is not common i.MX code - I can't only
make a review because it is difficult to read it.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================