[U-Boot] [PATCH 3/4] efikamx: update to Efika MX Smarttop and Smartbook boards

Marek Vasut
2012-08-17T23:38:07Z

Dear Matt Sealey,

> On Fri, Aug 17, 2012 at 4:07 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Matt Sealey,
> >
> >> Change summary:
> > This patch does multiple unrelated changes, please split. You basically
> > outlined how this should be split.
> >
> >> * Use iomux-mx51.h include to simplify board configuration.
> >> * Remove LED toggle function as it had no real users.
> >> * Red LED is now on for pre-reloc, Blue LED for "in U-Boot"
> >> * Function renames for readability.
> >> * Some board identification string changes
> >> * Reduce CPU core voltage to 1.1V (per TO3 spec)
> >> * Implicitly remove support for TO2 boards
> >
> > There are TO2 baords out there, debian people do have some. Please do not
> > remove this.
>
> The code I checked out from git master a week ago doesn't boot for
> precisely the same reason on TO2 r1.1 or r1.2 boards, so nothing
> changed here in real life. The TO2 code can't pass QA so it's been
> removed.

CCing Hector so he can supply further details about what debian does.

> Welcome to the wonderful world of commercial software
> development.

Your commercial goo has zero influence on any opensource project and noone gives
a splat, welcome to the wonderful world of _freedom_.*

* ok, maybe I'm negatively biased actually, especially due to the way you put
it.

Best regards,
Marek Vasut