* [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
@ 2012-08-18 23:28 Fabio Estevam
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Fabio Estevam @ 2012-08-18 23:28 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
There is no need to undef an option that is not enabled by default.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx28evk.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 4e70617..b677e51 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -215,7 +215,6 @@
#define CONFIG_SF_DEFAULT_SPEED 24000000
/* (redundant) environemnt in SPI flash */
-#undef CONFIG_ENV_IS_IN_SPI_FLASH
#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
#define CONFIG_SYS_REDUNDAND_ENVIRONMENT
#define CONFIG_ENV_SIZE 0x1000 /* 4KB */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
@ 2012-08-18 23:28 ` Fabio Estevam
2012-08-18 23:43 ` Marek Vasut
` (3 more replies)
2012-08-18 23:43 ` [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Marek Vasut
` (2 subsequent siblings)
3 siblings, 4 replies; 11+ messages in thread
From: Fabio Estevam @ 2012-08-18 23:28 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced
a mxs_dram_init() function, which is not used anywhere.
Fix it, so that the following warning goes away:
mx28evk.c: In function ?dram_init?:
mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h
index 9d1e599..4610363 100644
--- a/arch/arm/include/asm/arch-mxs/sys_proto.h
+++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
@@ -69,6 +69,6 @@ struct mxs_spl_data {
uint32_t mem_dram_size;
};
-int mxs_dram_init(void);
+int mx28_dram_init(void);
#endif /* __SYS_PROTO_H__ */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
@ 2012-08-18 23:43 ` Marek Vasut
2012-08-19 8:41 ` Stefano Babic
2012-08-20 8:02 ` Stefano Babic
3 siblings, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2012-08-18 23:43 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to undef an option that is not enabled by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx28evk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
> #define CONFIG_SF_DEFAULT_SPEED 24000000
>
> /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
> #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
@ 2012-08-18 23:43 ` Marek Vasut
2012-08-19 13:46 ` Otavio Salvador
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Marek Vasut @ 2012-08-18 23:43 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced
> a mxs_dram_init() function, which is not used anywhere.
>
> Fix it, so that the following warning goes away:
>
> mx28evk.c: In function ?dram_init?:
> mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init?
> [-Wimplicit-function-declaration]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h
> b/arch/arm/include/asm/arch-mxs/sys_proto.h index 9d1e599..4610363 100644
> --- a/arch/arm/include/asm/arch-mxs/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
> @@ -69,6 +69,6 @@ struct mxs_spl_data {
> uint32_t mem_dram_size;
> };
>
> -int mxs_dram_init(void);
> +int mx28_dram_init(void);
>
> #endif /* __SYS_PROTO_H__ */
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
2012-08-18 23:43 ` [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Marek Vasut
@ 2012-08-19 8:41 ` Stefano Babic
2012-08-20 8:02 ` Stefano Babic
3 siblings, 0 replies; 11+ messages in thread
From: Stefano Babic @ 2012-08-19 8:41 UTC (permalink / raw)
To: u-boot
On 19/08/2012 01:28, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to undef an option that is not enabled by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx28evk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
> #define CONFIG_SF_DEFAULT_SPEED 24000000
>
> /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
> #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
>
Acked-by: Stefano Babic <sbabic@denx.de>
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
2012-08-18 23:43 ` Marek Vasut
@ 2012-08-19 13:46 ` Otavio Salvador
2012-08-19 15:33 ` Fabio Estevam
2012-08-20 8:02 ` Stefano Babic
3 siblings, 0 replies; 11+ messages in thread
From: Otavio Salvador @ 2012-08-19 13:46 UTC (permalink / raw)
To: u-boot
On Sat, Aug 18, 2012 at 8:28 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced
> a mxs_dram_init() function, which is not used anywhere.
>
> Fix it, so that the following warning goes away:
>
> mx28evk.c: In function ?dram_init?:
> mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Otavio Salvador <otavio@ossystems.com.br>
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
2012-08-18 23:43 ` Marek Vasut
2012-08-19 13:46 ` Otavio Salvador
@ 2012-08-19 15:33 ` Fabio Estevam
2012-08-19 15:36 ` Fabio Estevam
2012-08-20 8:02 ` Stefano Babic
3 siblings, 1 reply; 11+ messages in thread
From: Fabio Estevam @ 2012-08-19 15:33 UTC (permalink / raw)
To: u-boot
Hi Stefano,
On Sat, Aug 18, 2012 at 8:28 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced
> a mxs_dram_init() function, which is not used anywhere.
>
> Fix it, so that the following warning goes away:
>
> mx28evk.c: In function ?dram_init?:
> mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Please discard this patch.
Otavio fixed it in another patch related to mx23 series.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-19 15:33 ` Fabio Estevam
@ 2012-08-19 15:36 ` Fabio Estevam
2012-08-19 15:39 ` Otavio Salvador
0 siblings, 1 reply; 11+ messages in thread
From: Fabio Estevam @ 2012-08-19 15:36 UTC (permalink / raw)
To: u-boot
On Sun, Aug 19, 2012 at 12:33 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Please discard this patch.
>
> Otavio fixed it in another patch related to mx23 series.
Ops, sorry. Otavio based his patch on top of mine, so this one needs
to be applied.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-19 15:36 ` Fabio Estevam
@ 2012-08-19 15:39 ` Otavio Salvador
0 siblings, 0 replies; 11+ messages in thread
From: Otavio Salvador @ 2012-08-19 15:39 UTC (permalink / raw)
To: u-boot
On Sun, Aug 19, 2012 at 12:36 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Sun, Aug 19, 2012 at 12:33 PM, Fabio Estevam <festevam@gmail.com> wrote:
>
>> Please discard this patch.
>>
>> Otavio fixed it in another patch related to mx23 series.
>
> Ops, sorry. Otavio based his patch on top of mine, so this one needs
> to be applied.
It shouldn't matter; GIT will do a 3way merge and apply I think.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef'
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
` (2 preceding siblings ...)
2012-08-19 8:41 ` Stefano Babic
@ 2012-08-20 8:02 ` Stefano Babic
3 siblings, 0 replies; 11+ messages in thread
From: Stefano Babic @ 2012-08-20 8:02 UTC (permalink / raw)
To: u-boot
On 19/08/2012 01:28, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> There is no need to undef an option that is not enabled by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx28evk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 4e70617..b677e51 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -215,7 +215,6 @@
> #define CONFIG_SF_DEFAULT_SPEED 24000000
>
> /* (redundant) environemnt in SPI flash */
> -#undef CONFIG_ENV_IS_IN_SPI_FLASH
> #ifdef CONFIG_ENV_IS_IN_SPI_FLASH
> #define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> #define CONFIG_ENV_SIZE 0x1000 /* 4KB */
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
` (2 preceding siblings ...)
2012-08-19 15:33 ` Fabio Estevam
@ 2012-08-20 8:02 ` Stefano Babic
3 siblings, 0 replies; 11+ messages in thread
From: Stefano Babic @ 2012-08-20 8:02 UTC (permalink / raw)
To: u-boot
On 19/08/2012 01:28, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> commit d92591a (mxs: Convert sys_proto.h prefixes to 'mxs') introduced
> a mxs_dram_init() function, which is not used anywhere.
>
> Fix it, so that the following warning goes away:
>
> mx28evk.c: In function ?dram_init?:
> mx28evk.c:67:2: warning: implicit declaration of function ?mx28_dram_init? [-Wimplicit-function-declaration]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/include/asm/arch-mxs/sys_proto.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mxs/sys_proto.h b/arch/arm/include/asm/arch-mxs/sys_proto.h
> index 9d1e599..4610363 100644
> --- a/arch/arm/include/asm/arch-mxs/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mxs/sys_proto.h
> @@ -69,6 +69,6 @@ struct mxs_spl_data {
> uint32_t mem_dram_size;
> };
>
> -int mxs_dram_init(void);
> +int mx28_dram_init(void);
>
> #endif /* __SYS_PROTO_H__ */
>
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-08-20 8:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-18 23:28 [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Fabio Estevam
2012-08-18 23:28 ` [U-Boot] [PATCH 2/2] mxs: Use correct function name to initialize dram Fabio Estevam
2012-08-18 23:43 ` Marek Vasut
2012-08-19 13:46 ` Otavio Salvador
2012-08-19 15:33 ` Fabio Estevam
2012-08-19 15:36 ` Fabio Estevam
2012-08-19 15:39 ` Otavio Salvador
2012-08-20 8:02 ` Stefano Babic
2012-08-18 23:43 ` [U-Boot] [PATCH 1/2] mx28evk: Remove unneeded 'undef' Marek Vasut
2012-08-19 8:41 ` Stefano Babic
2012-08-20 8:02 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox