public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mxs: Only build internal Ethernet controller for i.MX28
Date: Sun, 19 Aug 2012 17:06:58 +0200	[thread overview]
Message-ID: <201208191706.58622.marex@denx.de> (raw)
In-Reply-To: <1345388311-11920-2-git-send-email-otavio@ossystems.com.br>

Dear Otavio Salvador,

> The internal Ethernet controller is only available on i.MX28
> processors so it needs to use CONFIG_MX28 guardian to avoid having
> this code called in others.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> b/arch/arm/cpu/arm926ejs/mxs/mxs.c index c028e5e..a1769fd 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -246,7 +246,7 @@ int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int
> argc, char *const argv[]) /*
>   * Initializes on-chip ethernet controllers.
>   */
> -#ifdef	CONFIG_CMD_NET
> +#if defined(CONFIG_MX28) && defined(CONFIG_CMD_NET)
>  int cpu_eth_init(bd_t *bis)
>  {
>  	struct mxs_clkctrl_regs *clkctrl_regs =

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

  reply	other threads:[~2012-08-19 15:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-19 14:58 [U-Boot] [PATCH 1/3] mxs: Replace i.MX233 by i.MX23 on copyright header Otavio Salvador
2012-08-19 14:58 ` [U-Boot] [PATCH 2/3] mxs: Only build internal Ethernet controller for i.MX28 Otavio Salvador
2012-08-19 15:06   ` Marek Vasut [this message]
2012-08-19 14:58 ` [U-Boot] [PATCH 3/3] mxs: Rename 'mx28_dram_init' to 'mxs_dram_init' Otavio Salvador
2012-08-19 15:07   ` Marek Vasut
2012-08-23 23:06     ` Otavio Salvador
2012-08-24  7:57       ` Stefano Babic
2012-08-24  5:49   ` Veli-Pekka Peltola
2012-08-19 15:05 ` [U-Boot] [PATCH 1/3] mxs: Replace i.MX233 by i.MX23 on copyright header Marek Vasut
2012-08-19 15:07   ` Otavio Salvador
2012-08-27  5:46 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208191706.58622.marex@denx.de \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox