From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net: asix: add support for AX88772B
Date: Mon, 20 Aug 2012 20:27:54 +0200 [thread overview]
Message-ID: <201208202027.54263.marex@denx.de> (raw)
In-Reply-To: <1345485138-8511-1-git-send-email-dev@lynxeye.de>
Dear Lucas Stach,
> There are multiple changes needed to make AX88772B work:
>
> 1. add vendor and product ID (trivial)
>
> 2. We need to read out the MAC address from the EEPROM and write
> it into the NodeID register manually.
>
> 3. The packet length check has to be adjusted, as all ASIX chips
> only use 11 bits to indicate the length. AX88772B uses the other
> bits to indicate unrelated things, which cause the check to fail.
> This fix is based on a fix for the Linux kernel by Marek Vasut.
> Linux upstream commit: bca0beb9363f8487ac902931a50eb00180a2d14a
>
> 4. AX88772B provides several bulk endpoints. Only the first
> IN/OUT endpoints work in the default configuration. So stop
> enumeration after we found them to avoid overwriting the
> endpoint config with a non-working one.
>
> This was tested to work on a Colibri T20 board.
> Patch is based on u-boot-net/next.
>
> v2:
> - split out eeprom mac load into separate function
> - add flags to driver to get a clean way to enable workarounds
> or special functions
[...]
Quick review looks fine to me, Joe?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-20 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 17:52 [U-Boot] [PATCH v2] net: asix: add support for AX88772B Lucas Stach
2012-08-20 18:27 ` Marek Vasut [this message]
2012-08-20 19:21 ` Mike Frysinger
2012-08-20 19:45 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208202027.54263.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox