From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 20 Aug 2012 20:27:54 +0200
Subject: [U-Boot] [PATCH v2] net: asix: add support for AX88772B
In-Reply-To: <1345485138-8511-1-git-send-email-dev@lynxeye.de>
References: <1345485138-8511-1-git-send-email-dev@lynxeye.de>
Message-ID: <201208202027.54263.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lucas Stach,

> There are multiple changes needed to make AX88772B work:
> 
> 1. add vendor and product ID (trivial)
> 
> 2. We need to read out the MAC address from the EEPROM and write
> it into the NodeID register manually.
> 
> 3. The packet length check has to be adjusted, as all ASIX chips
> only use 11 bits to indicate the length. AX88772B uses the other
> bits to indicate unrelated things, which cause the check to fail.
> This fix is based on a fix for the Linux kernel by Marek Vasut.
> Linux upstream commit: bca0beb9363f8487ac902931a50eb00180a2d14a
> 
> 4. AX88772B provides several bulk endpoints. Only the first
> IN/OUT endpoints work in the default configuration. So stop
> enumeration after we found them to avoid overwriting the
> endpoint config with a non-working one.
> 
> This was tested to work on a Colibri T20 board.
> Patch is based on u-boot-net/next.
> 
> v2:
> - split out eeprom mac load into separate function
> - add flags to driver to get a clean way to enable workarounds
>   or special functions
[...]

Quick review looks fine to me, Joe?

Best regards,
Marek Vasut