From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] pxa25x: Add USB ethernet gadget
Date: Wed, 22 Aug 2012 20:18:51 +0200 [thread overview]
Message-ID: <201208222018.51443.marex@denx.de> (raw)
In-Reply-To: <1345558171-26874-3-git-send-email-luk0104@gmail.com>
Dear ?ukasz Da?ek,
> Signed-off-by: ?ukasz Da?ek <luk0104@gmail.com>
> ---
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/pxa25x_udc.c | 2059
> +++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/pxa25x_udc.h |
> 168 ++++
> 3 files changed, 2228 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/gadget/pxa25x_udc.c
> create mode 100644 drivers/usb/gadget/pxa25x_udc.h
[...]
Quick glance seems mostly OK.
> -*/ +
> +#ifdef DEBUG
> +# ifdef DEBUG_NOISY
> +# define NOISY 1
> +# else
> +# define NOISY 0
> +# endif
> +#else
> +# define NOISY 0
> +#endif
So ... define DEBUG_NOISY always and set it to some value ... then you won't
need this additional NOISY at all.
> +#endif /* __LINUX_USB_GADGET_PXA25X_H */
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-22 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 14:09 [U-Boot] [PATCH 0/2] PXA25x: USB ethernet driver Łukasz Dałek
2012-08-21 14:09 ` [U-Boot] [PATCH 1/2] pxa: Add some stuff to examine cpu model and rev Łukasz Dałek
2012-08-21 20:55 ` Marek Vasut
2012-08-21 14:09 ` [U-Boot] [PATCH 2/2] pxa25x: Add USB ethernet gadget Łukasz Dałek
2012-08-22 18:18 ` Marek Vasut [this message]
2012-08-21 15:21 ` [U-Boot] [PATCH 0/2] PXA25x: USB ethernet driver Marek Vasut
2012-08-30 19:09 ` Marek Vasut
2012-08-30 22:02 ` Łukasz Dałek
2012-08-30 22:04 ` Marek Vasut
2012-08-30 22:11 ` Łukasz Dałek
2012-08-31 1:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208222018.51443.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox