From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 22 Aug 2012 20:18:51 +0200
Subject: [U-Boot] [PATCH 2/2] pxa25x: Add USB ethernet gadget
In-Reply-To: <1345558171-26874-3-git-send-email-luk0104@gmail.com>
References: <1345558171-26874-1-git-send-email-luk0104@gmail.com>
	<1345558171-26874-3-git-send-email-luk0104@gmail.com>
Message-ID: <201208222018.51443.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear ?ukasz Da?ek,

> Signed-off-by: ?ukasz Da?ek <luk0104@gmail.com>
> ---
>  drivers/usb/gadget/Makefile     |    1 +
>  drivers/usb/gadget/pxa25x_udc.c | 2059
> +++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/pxa25x_udc.h | 
> 168 ++++
>  3 files changed, 2228 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/gadget/pxa25x_udc.c
>  create mode 100644 drivers/usb/gadget/pxa25x_udc.h

[...]

Quick glance seems mostly OK.

> -*/ +
> +#ifdef DEBUG
> +# ifdef DEBUG_NOISY
> +#  define NOISY 1
> +# else
> +#  define NOISY 0
> +# endif
> +#else
> +# define NOISY 0
> +#endif

So ... define DEBUG_NOISY always and set it to some value ... then you won't 
need this additional NOISY at all.

> +#endif /* __LINUX_USB_GADGET_PXA25X_H */

Best regards,
Marek Vasut