From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/6] net: usbeth: remove misleading warning
Date: Wed, 22 Aug 2012 20:22:49 +0200 [thread overview]
Message-ID: <201208222022.49653.marex@denx.de> (raw)
In-Reply-To: <1345630147-14465-3-git-send-email-dev@lynxeye.de>
Dear Lucas Stach,
> If the environment doesn't provide a MAC address it's not an
> error to use the one provided by the eth adapter. Actually it
> should be the default case if the adapter exports it's own
> address during get_info().
I think we should warn if the addr in env doesn't match the one in the device.
Otherwise, if the env doesn't contain ethaddr (or eth1addr, eth2addr ...), pull
one from the device and inform user.
> So just remove the warning that gets printed in this case.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> net/eth.c | 2 --
> 1 Datei ge?ndert, 2 Zeilen entfernt(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 1a11ce1..39cd5da 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -217,8 +217,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char
> *base_name, } else if (is_valid_ether_addr(dev->enetaddr)) {
> eth_setenv_enetaddr_by_index(base_name, eth_number,
> dev->enetaddr);
> - printf("\nWarning: %s using MAC address from net device\n",
> - dev->name);
> }
>
> if (dev->write_hwaddr &&
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-22 18:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:09 [U-Boot] [PATCH 0/6] net: ASIX AX88772B enablement Lucas Stach
2012-08-22 10:09 ` [U-Boot] [PATCH 1/6] net: introduce transparent driver private in ueth_data Lucas Stach
2012-08-22 18:21 ` Marek Vasut
2012-08-22 18:49 ` Joe Hershberger
2012-08-22 10:09 ` [U-Boot] [PATCH 2/6] net: usbeth: remove misleading warning Lucas Stach
2012-08-22 18:22 ` Marek Vasut [this message]
2012-08-22 18:32 ` Lucas Stach
2012-08-22 18:46 ` Joe Hershberger
2012-08-22 10:09 ` [U-Boot] [PATCH 3/6] net: asix: split out basic reset function Lucas Stach
2012-08-22 18:23 ` Marek Vasut
2012-08-22 18:52 ` Joe Hershberger
2012-08-23 3:01 ` Mike Frysinger
2012-08-23 8:37 ` Lucas Stach
2012-08-22 10:09 ` [U-Boot] [PATCH 4/6] net: asix: add write_hwaddr function Lucas Stach
2012-08-22 18:25 ` Marek Vasut
2012-08-22 19:04 ` Joe Hershberger
2012-08-22 10:09 ` [U-Boot] [PATCH 5/6] net: asix: add read_mac function Lucas Stach
2012-08-22 18:26 ` Marek Vasut
2012-08-22 18:59 ` Joe Hershberger
2012-08-22 10:09 ` [U-Boot] [PATCH 6/6] net: asix: add AX88772B support Lucas Stach
2012-08-22 18:26 ` Marek Vasut
2012-08-22 19:01 ` Joe Hershberger
2012-08-22 18:20 ` [U-Boot] [PATCH 0/6] net: ASIX AX88772B enablement Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208222022.49653.marex@denx.de \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox