[U-Boot] [PATCH 2/6] net: usbeth: remove misleading warning

Marek Vasut
2012-08-22T18:22:49Z

Dear Lucas Stach,

> If the environment doesn't provide a MAC address it's not an
> error to use the one provided by the eth adapter. Actually it
> should be the default case if the adapter exports it's own
> address during get_info().

I think we should warn if the addr in env doesn't match the one in the device.
Otherwise, if the env doesn't contain ethaddr (or eth1addr, eth2addr ...), pull
one from the device and inform user.

> So just remove the warning that gets printed in this case.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> net/eth.c | 2 --
> 1 Datei ge?ndert, 2 Zeilen entfernt(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 1a11ce1..39cd5da 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -217,8 +217,6 @@ int eth_write_hwaddr(struct eth_device *dev, const char
> *base_name, } else if (is_valid_ether_addr(dev->enetaddr)) {
> eth_setenv_enetaddr_by_index(base_name, eth_number,
> dev->enetaddr);
> - printf("\nWarning: %s using MAC address from net device\n",
> - dev->name);
> }
>
> if (dev->write_hwaddr &&

Best regards,
Marek Vasut