[U-Boot] [PATCH 3/6] net: asix: split out basic reset function

[Mike Frysinger <vapier@gentoo.org>]

On Wednesday 22 August 2012 06:09:04 Lucas Stach wrote:
> The basic device reset ensures that the device is ready to
> service commands and does not need to get redone before each
> network operation.
> 
> Split out the basic reset from asix_init() and instead call it
> from asix_eth_get_info(), so that it only gets called once.

i'm afraid this is wrong.  the register step (which asix_eth_get_info is 
afaict) should not touch the hardware (other than to extract the MAC address).  
the init func is supposed to bring up the hardware from scratch since the 
expectation is that the halt func brings it down completely.  if it's not 
really possible to completely "bring down" the hardware, then have the 
asix_init func declare a local static int so that it does the "full" bring up 
only once.

so NAK this patch as is
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120822/628fa7d0/attachment.pgp>