public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus
Date: Wed, 22 Aug 2012 23:07:21 -0400	[thread overview]
Message-ID: <201208222307.22192.vapier@gentoo.org> (raw)
In-Reply-To: <1345472551-1546-2-git-send-email-etou.zh@gmail.com>

On Monday 20 August 2012 10:22:23 Zhizhou Zhang wrote:
> +void __weak _machine_restart(void)
> +{
> +}

this should be:
void __noreturn __weak _machine_restart(void)
{
	while (1);
}

there should also be a prototype for this in one of the mips64 headers

> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> +	_machine_restart();
> +
> +	fprintf(stderr, "*** reset failed ***\n");
> +	return 0;
> +}

then this would be:
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
	_machine_restart();
}
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120822/ae49f656/attachment.pgp>

  reply	other threads:[~2012-08-23  3:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 14:22 [U-Boot] [Patch V3 0/4] add mips64 cpu support Zhizhou Zhang
2012-08-20 14:22 ` [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus Zhizhou Zhang
2012-08-23  3:07   ` Mike Frysinger [this message]
2012-08-23 13:57     ` Zhi-zhou Zhang
2012-08-24  0:22   ` Daniel Schwierzeck
2012-08-26  3:10     ` Zhi-zhou Zhang
2012-08-26 12:12     ` Zhi-zhou Zhang
2012-08-26 14:23       ` Daniel Schwierzeck
2012-08-20 14:22 ` [U-Boot] [Patch V3 2/4] [MIPS] add mips64 support in mips head files Zhizhou Zhang
2012-08-24  0:22   ` Daniel Schwierzeck
2012-08-20 14:22 ` [U-Boot] [Patch V3 3/4] [MIPS] Add qemu-mips building configs Zhizhou Zhang
2012-08-24  0:23   ` Daniel Schwierzeck
2012-08-20 14:22 ` [U-Boot] [Patch V3 4/4] [MIPS] Disable standalone while building MIPS64 Zhizhou Zhang
2012-08-24  0:23   ` Daniel Schwierzeck
2012-08-26 12:45     ` Zhi-zhou Zhang
2012-08-26 13:33       ` Daniel Schwierzeck
2012-08-20 14:22 ` [U-Boot] [Patch V3 0/4] add mips64 cpu support Zhizhou Zhang
2012-08-20 14:22 ` [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus Zhizhou Zhang
2012-08-20 14:22 ` [U-Boot] [Patch V3 2/4] [MIPS] add mips64 support in mips head files Zhizhou Zhang
2012-08-20 14:22 ` [U-Boot] [Patch V3 3/4] [MIPS] Add qemu-mips building configs Zhizhou Zhang
2012-08-20 14:22 ` [U-Boot] [Patch V3 4/4] [MIPS] Disable standalone while building MIPS64 Zhizhou Zhang
2012-08-23  3:04 ` [U-Boot] [Patch V3 0/4] add mips64 cpu support Mike Frysinger
2012-08-23 14:14   ` Zhi-zhou Zhang
2012-08-24  0:21 ` Daniel Schwierzeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208222307.22192.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox