From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 22 Aug 2012 23:07:21 -0400
Subject: [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus
In-Reply-To: <1345472551-1546-2-git-send-email-etou.zh@gmail.com>
References: <1345472551-1546-1-git-send-email-etou.zh@gmail.com>
	<1345472551-1546-2-git-send-email-etou.zh@gmail.com>
Message-ID: <201208222307.22192.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 20 August 2012 10:22:23 Zhizhou Zhang wrote:
> +void __weak _machine_restart(void)
> +{
> +}

this should be:
void __noreturn __weak _machine_restart(void)
{
	while (1);
}

there should also be a prototype for this in one of the mips64 headers

> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> +	_machine_restart();
> +
> +	fprintf(stderr, "*** reset failed ***\n");
> +	return 0;
> +}

then this would be:
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
	_machine_restart();
}
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120822/ae49f656/attachment.pgp>