From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sughosh Ganu Date: Tue, 28 Aug 2012 01:04:50 +0530 Subject: [U-Boot] [PATCH v4 11/20] ARM: SPL: Clean up spl.c / spl_nand.c slightly In-Reply-To: <1345852714-13138-12-git-send-email-trini@ti.com> References: <1345852714-13138-1-git-send-email-trini@ti.com> <1345852714-13138-12-git-send-email-trini@ti.com> Message-ID: <20120827193450.GC3322@Hardy> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri Aug 24, 2012 at 04:58:25PM -0700, Tom Rini wrote: > - Remove includes we don't need > - Switch some printf statements to puts > - Convert some printf statements to debug, introduce new puts statements > - In most cases saying just "No mkimage signature, assuming > u-boot.bin" or similar is sufficient. This also means the non-DEBUG > case doesn't need printf, in the core of SPL. > - The other case here is that PLAIN_VERSION provided what we wanted > already, so just use it. > > Signed-off-by: Tom Rini > --- > @@ -99,9 +96,9 @@ void spl_parse_image_header(const struct image_header *header) > spl_image.name, spl_image.load_addr, spl_image.size); > } else { > /* Signature not found - assume u-boot.bin */ > - printf("mkimage signature not found - ih_magic = %x\n", > + puts("mkimage signature not found, assuming u-boot.bin ..\n"); Just a nit. Can the above be made a debug statement instead, like how it was earlier. I guess it's a bit superfluous -- also the other case just has a debug. Don't have a strong opinion about this though, just find it a bit annoying that this gets printed at every boot :). > + debug("mkimage signature not found - ih_magic = %x\n", > header->ih_magic); > - debug("Assuming u-boot.bin ..\n"); > /* Let's assume U-Boot will not be more than 200 KB */ > spl_image.size = 200 * 1024; > spl_image.entry_point = CONFIG_SYS_TEXT_BASE; -sughosh