* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
@ 2012-08-28 19:29 Fabio Estevam
2012-08-28 19:36 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Fabio Estevam @ 2012-08-28 19:29 UTC (permalink / raw)
To: u-boot
Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
missed to update mx28evk, which caused the board not to boot.
Apply the conversion so that the board can boot again.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/mx28evk/iomux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/mx28evk/iomux.c b/board/freescale/mx28evk/iomux.c
index 16a6d8a..ae6eda3 100644
--- a/board/freescale/mx28evk/iomux.c
+++ b/board/freescale/mx28evk/iomux.c
@@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
#define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
ADDR_PINS << 8 | APREBIT)
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
{
dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-08-28 19:29 [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params() Fabio Estevam
@ 2012-08-28 19:36 ` Marek Vasut
2012-08-28 19:39 ` Marek Vasut
2012-08-28 21:49 ` Otavio Salvador
2012-09-03 16:47 ` Fabio Estevam
2012-09-04 10:04 ` Stefano Babic
2 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2012-08-28 19:36 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> Recent conversion from mx28_adjust_memory_params to
> mxs_adjust_memory_params missed to update mx28evk, which caused the board
> not to boot.
Oh of course ... that's an obvious flub. I'm very unhappy about the conversion
causing such trouble! Please be more careful next time.
> Apply the conversion so that the board can boot again.
Yes,
Acked-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/mx28evk/iomux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx28evk/iomux.c
> b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
> --- a/board/freescale/mx28evk/iomux.c
> +++ b/board/freescale/mx28evk/iomux.c
> @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
> #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
> ADDR_PINS << 8 | APREBIT)
>
> -void mx28_adjust_memory_params(uint32_t *dram_vals)
> +void mxs_adjust_memory_params(uint32_t *dram_vals)
> {
> dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-08-28 19:36 ` Marek Vasut
@ 2012-08-28 19:39 ` Marek Vasut
2012-08-28 21:49 ` Otavio Salvador
1 sibling, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-08-28 19:39 UTC (permalink / raw)
To: u-boot
Dear Marek Vasut,
> Dear Fabio Estevam,
>
> > Recent conversion from mx28_adjust_memory_params to
> > mxs_adjust_memory_params missed to update mx28evk, which caused the board
> > not to boot.
>
> Oh of course ... that's an obvious flub. I'm very unhappy about the
> conversion causing such trouble! Please be more careful next time.
btw. Otavio, tell me if this tortured you enough ... gotta train this, I'm not
good at it yet, but fear, soon I'll improve ;-)
> > Apply the conversion so that the board can boot again.
>
> Yes,
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> >
> > board/freescale/mx28evk/iomux.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/freescale/mx28evk/iomux.c
> > b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
> > --- a/board/freescale/mx28evk/iomux.c
> > +++ b/board/freescale/mx28evk/iomux.c
> > @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
> >
> > #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
> >
> > ADDR_PINS << 8 | APREBIT)
> >
> > -void mx28_adjust_memory_params(uint32_t *dram_vals)
> > +void mxs_adjust_memory_params(uint32_t *dram_vals)
> >
> > {
> >
> > dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
> >
> > }
>
> Best regards,
> Marek Vasut
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-08-28 19:36 ` Marek Vasut
2012-08-28 19:39 ` Marek Vasut
@ 2012-08-28 21:49 ` Otavio Salvador
1 sibling, 0 replies; 7+ messages in thread
From: Otavio Salvador @ 2012-08-28 21:49 UTC (permalink / raw)
To: u-boot
On Tue, Aug 28, 2012 at 4:36 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Fabio Estevam,
>
>> Recent conversion from mx28_adjust_memory_params to
>> mxs_adjust_memory_params missed to update mx28evk, which caused the board
>> not to boot.
>
> Oh of course ... that's an obvious flub. I'm very unhappy about the conversion
> causing such trouble! Please be more careful next time.
This was my fault; but good that Fabio has spot it fast.
>> Apply the conversion so that the board can boot again.
>
> Yes,
>
> Acked-by: Marek Vasut <marex@denx.de>
>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> board/freescale/mx28evk/iomux.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/freescale/mx28evk/iomux.c
>> b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
>> --- a/board/freescale/mx28evk/iomux.c
>> +++ b/board/freescale/mx28evk/iomux.c
>> @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
>> #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
>> ADDR_PINS << 8 | APREBIT)
>>
>> -void mx28_adjust_memory_params(uint32_t *dram_vals)
>> +void mxs_adjust_memory_params(uint32_t *dram_vals)
>> {
>> dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
>> }
>
> Best regards,
> Marek Vasut
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-08-28 19:29 [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params() Fabio Estevam
2012-08-28 19:36 ` Marek Vasut
@ 2012-09-03 16:47 ` Fabio Estevam
2012-09-03 17:21 ` Stefano Babic
2012-09-04 10:04 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2012-09-03 16:47 UTC (permalink / raw)
To: u-boot
Hi Stefano,
On Tue, Aug 28, 2012 at 4:29 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
> missed to update mx28evk, which caused the board not to boot.
>
> Apply the conversion so that the board can boot again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Could this one be applied, please?
Without this patch, mx28evk does not boot.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-09-03 16:47 ` Fabio Estevam
@ 2012-09-03 17:21 ` Stefano Babic
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2012-09-03 17:21 UTC (permalink / raw)
To: u-boot
On 03/09/2012 18:47, Fabio Estevam wrote:
> Hi Stefano,
>
> On Tue, Aug 28, 2012 at 4:29 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
>> missed to update mx28evk, which caused the board not to boot.
>>
>> Apply the conversion so that the board can boot again.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Could this one be applied, please?
>
> Without this patch, mx28evk does not boot.
Sorry - I will merge it soon.
Cheers,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
2012-08-28 19:29 [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params() Fabio Estevam
2012-08-28 19:36 ` Marek Vasut
2012-09-03 16:47 ` Fabio Estevam
@ 2012-09-04 10:04 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2012-09-04 10:04 UTC (permalink / raw)
To: u-boot
On 28/08/2012 21:29, Fabio Estevam wrote:
> Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params
> missed to update mx28evk, which caused the board not to boot.
>
> Apply the conversion so that the board can boot again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-09-04 10:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 19:29 [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params() Fabio Estevam
2012-08-28 19:36 ` Marek Vasut
2012-08-28 19:39 ` Marek Vasut
2012-08-28 21:49 ` Otavio Salvador
2012-09-03 16:47 ` Fabio Estevam
2012-09-03 17:21 ` Stefano Babic
2012-09-04 10:04 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox