public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed
Date: Wed, 29 Aug 2012 03:17:45 +0200	[thread overview]
Message-ID: <201208290317.46130.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrwBYeXRUF=ErSYjgdT4ytNKHQVV8R=-6peVSO4Q35vmw@mail.gmail.com>

Dear Otavio Salvador,

> On Tue, Aug 28, 2012 at 7:18 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Dear Otavio Salvador,
> > 
> >> Align the SSP clock speed with oscilator to achieve higher transfer
> >> stability.
> > 
> > This change is still pointless, unless you have user for this!
> 
> As far as I know the SPI flash uses SSP2; so it is a user of it.

So, why dont you also align the default clockspeed of the spi flash attached to 
ssp2 in the config file within this patch?

Lemme answer myself after taking a look ... because that's already done.

Ok,

Acked-by: Marek Vasut <marex@denx.de>

> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> Changes in v2:
> >> - reword commit log to match the change description done on m28evk.
> >> 
> >>  board/freescale/mx28evk/mx28evk.c |    4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/board/freescale/mx28evk/mx28evk.c
> >> b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
> >> --- a/board/freescale/mx28evk/mx28evk.c
> >> +++ b/board/freescale/mx28evk/mx28evk.c
> >> @@ -49,8 +49,8 @@ int board_early_init_f(void)
> >> 
> >>       /* SSP0 clock at 96MHz */
> >>       mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
> >> 
> >> -     /* SSP2 clock at 96MHz */
> >> -     mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
> >> +     /* SSP2 clock at 160MHz */
> >> +     mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
> >> 
> >>  #ifdef       CONFIG_CMD_USB
> >>  
> >>       mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

  reply	other threads:[~2012-08-29  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  9:56 [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Otavio Salvador
2012-08-28  9:56 ` [U-Boot] [PATCH v2 2/2] MX28: mx28evk: Enable SPI DMA Otavio Salvador
2012-09-04 10:04   ` Stefano Babic
2012-08-28 10:18 ` [U-Boot] [PATCH v2 1/2] MX28: mx28evk: Align SSP clock speed Marek Vasut
2012-08-28 21:47   ` Otavio Salvador
2012-08-29  1:17     ` Marek Vasut [this message]
2012-09-04 10:04 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208290317.46130.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox