From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci: don't print debug output
Date: Thu, 30 Aug 2012 17:47:19 +0200 [thread overview]
Message-ID: <201208301747.19631.marex@denx.de> (raw)
In-Reply-To: <1346341136-12802-1-git-send-email-dev@lynxeye.de>
Dear Lucas Stach,
> This is clearly some sort of debug output and should not
> be printed during normal operation.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
I think we should apply this ... yet it's been in uboot for so long, so I'd like
to hear other people opinion :)
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 2f4fa5e..eb9e323 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
>
> reg = ehci_readl(&hccr->cr_hcsparams);
> descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
> - printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> + debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> /* Port Indicators */
> if (HCS_INDICATOR(reg))
> descriptor.hub.wHubCharacteristics |= 0x80;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-30 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 15:38 [U-Boot] [PATCH] usb: ehci: don't print debug output Lucas Stach
2012-08-30 15:47 ` Marek Vasut [this message]
2012-09-27 20:02 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208301747.19631.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox