From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 30 Aug 2012 17:47:19 +0200 Subject: [U-Boot] [PATCH] usb: ehci: don't print debug output In-Reply-To: <1346341136-12802-1-git-send-email-dev@lynxeye.de> References: <1346341136-12802-1-git-send-email-dev@lynxeye.de> Message-ID: <201208301747.19631.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lucas Stach, > This is clearly some sort of debug output and should not > be printed during normal operation. > > Signed-off-by: Lucas Stach I think we should apply this ... yet it's been in uboot for so long, so I'd like to hear other people opinion :) > --- > drivers/usb/host/ehci-hcd.c | 2 +- > 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 2f4fa5e..eb9e323 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -863,7 +863,7 @@ int usb_lowlevel_init(void) > > reg = ehci_readl(&hccr->cr_hcsparams); > descriptor.hub.bNbrPorts = HCS_N_PORTS(reg); > - printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts); > + debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts); > /* Port Indicators */ > if (HCS_INDICATOR(reg)) > descriptor.hub.wHubCharacteristics |= 0x80; Best regards, Marek Vasut