* [U-Boot] [PATCH] usb: ehci: don't print debug output
@ 2012-08-30 15:38 Lucas Stach
2012-08-30 15:47 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2012-08-30 15:38 UTC (permalink / raw)
To: u-boot
This is clearly some sort of debug output and should not
be printed during normal operation.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
drivers/usb/host/ehci-hcd.c | 2 +-
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 2f4fa5e..eb9e323 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
reg = ehci_readl(&hccr->cr_hcsparams);
descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
- printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
+ debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
/* Port Indicators */
if (HCS_INDICATOR(reg))
descriptor.hub.wHubCharacteristics |= 0x80;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] usb: ehci: don't print debug output
2012-08-30 15:38 [U-Boot] [PATCH] usb: ehci: don't print debug output Lucas Stach
@ 2012-08-30 15:47 ` Marek Vasut
2012-09-27 20:02 ` Lucas Stach
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2012-08-30 15:47 UTC (permalink / raw)
To: u-boot
Dear Lucas Stach,
> This is clearly some sort of debug output and should not
> be printed during normal operation.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
I think we should apply this ... yet it's been in uboot for so long, so I'd like
to hear other people opinion :)
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 2f4fa5e..eb9e323 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
>
> reg = ehci_readl(&hccr->cr_hcsparams);
> descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
> - printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> + debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> /* Port Indicators */
> if (HCS_INDICATOR(reg))
> descriptor.hub.wHubCharacteristics |= 0x80;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] usb: ehci: don't print debug output
2012-08-30 15:47 ` Marek Vasut
@ 2012-09-27 20:02 ` Lucas Stach
0 siblings, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2012-09-27 20:02 UTC (permalink / raw)
To: u-boot
Hi Marek,
Am Donnerstag, den 30.08.2012, 17:47 +0200 schrieb Marek Vasut:
> Dear Lucas Stach,
>
> > This is clearly some sort of debug output and should not
> > be printed during normal operation.
> >
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
>
> I think we should apply this ... yet it's been in uboot for so long, so I'd like
> to hear other people opinion :)
>
Any updates on this one? Seems nobody really cares and it uglyfies
output in the multi controller case a lot, so I really wish to see this
gone.
> > ---
> > drivers/usb/host/ehci-hcd.c | 2 +-
> > 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 2f4fa5e..eb9e323 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
> >
> > reg = ehci_readl(&hccr->cr_hcsparams);
> > descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
> > - printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> > + debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
> > /* Port Indicators */
> > if (HCS_INDICATOR(reg))
> > descriptor.hub.wHubCharacteristics |= 0x80;
>
> Best regards,
> Marek Vasut
>
Thanks,
Lucas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-27 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-30 15:38 [U-Boot] [PATCH] usb: ehci: don't print debug output Lucas Stach
2012-08-30 15:47 ` Marek Vasut
2012-09-27 20:02 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox