[U-Boot] [PATCHv1] ARM: Add Altera SOCFPGA Cyclone5

Pavel Machek
2012-08-25T11:56:01Z

Hi!

> [snip]
> >> It's the omap-common/spl.c code with the bits for IH_OS_LINUX taken out
> >> :) Can you please re-do your series on top of the SPL series I just
> >> posted that provides a common SPL framework? Thanks!
> >
> > I'll take a look. OTOH, ammount of code duplication here is quite low,
> > and redoing it on top of SPL series will mean delaying merge, right?
>
> My hope is that since I got the SPL patches posted in time we can get
> them in for v2012.10 so no, this will only help your chances :)

Hopefully.

Some observations:

Not sure what to do with CONFIG_SPL_STACK: altera was just using
symbol from linker script. Is there way to keep it like that? I'd hate
to invent magic constant.

Same issue with CONFIG_SYS_SPL_MALLOC_START... I was doing:

/* setup MALLOC after clocks going faster */
mem_malloc_init((ulong) &__malloc_start,
(&__malloc_end -
&__malloc_start));

I guess defines allow me to keep my definition. Good.

spl_parse_image_header(): We have "modern" system, we'd prefer not to
do
/* Signature not found - assume u-boot.bin */
...but to hang in that case, in order not to jump to random code.

Ok, I should have something publishable, soon ;-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html