[U-Boot] [PATCHv1] ARM: Add Altera SOCFPGA Cyclone5

Tom Rini
2012-08-30T17:46:09Z

On 08/30/2012 10:34 AM, Tom Rini wrote:
> On 08/30/2012 10:18 AM, Pavel Machek wrote:
>
>>>> + * miscellaneous platform dependent initialisations
>>>> + */
>>>> +int misc_init_r(void)
>>>> +{
>>>> + /* Set to "n" for not verifying the uImage */
>>>> + setenv("verify", "n");
>>>> + return 0;
>>>> +}
>>>
>>> Not good to enforce policy like this. Just don't set it in the config
>>> file by default and let users do as they need.
>>
>> Hmm. I moved it to CONFIG_EXTRA_ENV_SETTINGS as done by for eample
>> u8500_href.h. Is that ok?
>
> It defaults to no, I believe is the thing (so yes, there's a few bad
> examples out there including, urk, one that I own).

I take it back, yes is the default, so yes, doing
CONFIG_EXTRA_ENV_SETTINGS with verify=no is correct.

--
Tom