From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 30 Aug 2012 23:09:27 +0200
Subject: [U-Boot] [PATCH 2/4] usb: ehci: rework to take advantage of new
	lowlevel interface
In-Reply-To: <1346342604-13355-3-git-send-email-dev@lynxeye.de>
References: <1346342604-13355-1-git-send-email-dev@lynxeye.de>
	<1346342604-13355-3-git-send-email-dev@lynxeye.de>
Message-ID: <201208302309.27159.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lucas Stach,

> Kill off ehci-core.h
> It was used to specify some static controller data. To support more than
> one controller being active at any time we have to carry the controller
> data ourselfes. Change the ehci interface accordingly.
> 
> NOTE: OMAP implemented the ehci stuff a bit backwards and should be fixed
> to do the same thing as other platforms. But the change for now is at least
> compile clean.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
[...]

The omap change could be separated out, no?
Also, I'd fix all these &(*something)->somethingelse if possible.

Otherwise,

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut