public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] pull request for u-boot-tegra/master
Date: Fri, 31 Aug 2012 08:32:37 +0200	[thread overview]
Message-ID: <20120831083237.3dd3419b@lilith> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F379E006051@HQMAIL04.nvidia.com>

Hi Tom,

On Thu, 30 Aug 2012 17:14:09 -0700, Tom Warren <TWarren@nvidia.com>
wrote:

> Seems to be the root Makefile:
> 
> ifeq ($(SOC),tegra20)
> -LIBS += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o
> +LIBS-y += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o
> endif
> 
>  fixes it, i.e. ./MAKEALL -s tegra20 w/arm/master branch pullreq-utm
> passes. This change from Daniel Schwierzeck (Makefile: replace LIBS
> by LIBS-y) wasn't in the ARM repo I sync'd to before I sent the pull
> request. I assume it came from ARM/master since then, or maybe from
> u-boot/master.

Thanks for the analysis.

It *could* be a previous attempt of mine at pulling into ARM some
branch where this fix was in and then having to revert to a previous
arm/master due to regressions, and your branch was left based on the
temporary arm/master with the fix.

The only way to avoid this is to strictly follow U-Boot policies for
pull requests: always rebase onto the target branch before sending out
a pull request, i.e. pull requests to u-boot-arm/master should always
be (re)based on u-boot-arm/master, and my ARM pull requests to
u-boot/master should always be (re)based on u-boot/master.

> Looks like we'll need a v11 tegra20 SPL patchset, unless Albert is
> willing to slip-stream this minor fix in.

I'll pick Daniel's commit individually, then locally rebase your branch
with the V10 SPL patch set. If regression builds are ok, I'll send out
the 'applied' for Daniel's patch and your pull req.

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2012-08-31  6:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 23:25 [U-Boot] pull request for u-boot-tegra/master Tom Warren
     [not found] ` <20120818212141.3e4f5a3a@lilith>
     [not found]   ` <CA+m5__J7O=YYWEwTGqTBqiagTL+YU3BR-TyE5M2W_xdesVWqmA@mail.gmail.com>
     [not found]     ` <5032684A.2040703@ti.com>
     [not found]       ` <CA+m5__+prjk_GgvK5uZf1m23t3nsSiYu-nYRcci4my59q7T6-w@mail.gmail.com>
     [not found]         ` <CA+m5__Kiq0-ZYjarTXZRFZTC71wWV=c0fmzCJW=-Dt5fgK+dxA@mail.gmail.com>
     [not found]           ` <20120825103410.7fc86952@lilith>
     [not found]             ` <20120828165448.GD9587@nvidia.com>
     [not found]               ` <20120830083325.031e31d4@lilith>
     [not found]                 ` <CA+m5__+gNxyB1nVSe-8DTE=seqBvOQTz2NsPTh=h3kTOCY9rCw@mail.gmail.com>
     [not found]                   ` <20120830224742.678423bc@lilith>
     [not found]                     ` <5FBF8E85CA34454794F0F7ECBA79798F379E005FB3@HQMAIL04.nvidia.com>
     [not found]                       ` <20120830234733.1aea4c7e@lilith>
     [not found]                         ` <5FBF8E85CA34454794F0F7ECBA79798F379E006051@HQMAIL04.nvidia.com>
2012-08-31  6:32                           ` Albert ARIBAUD [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-31 21:28 Tom Warren
2012-09-01  6:56 ` Albert ARIBAUD
2012-07-30 20:07 Tom Warren
2012-08-03 23:35 ` Tom Warren
2012-08-05 19:46   ` Albert ARIBAUD
2012-08-05 20:01     ` Albert ARIBAUD
2012-08-06 15:53       ` Tom Warren
2012-08-06 17:37         ` Allen Martin
2012-08-06 22:46         ` Allen Martin
2012-08-07  6:53           ` Albert ARIBAUD
2012-08-07 16:03             ` Tom Warren
2012-08-07 17:15             ` Allen Martin
2012-08-06 15:18     ` Tom Warren
2012-08-07 16:27 ` Tom Warren
2012-07-09 17:49 Tom Warren
2012-07-09 20:42 ` Albert ARIBAUD
2012-05-31 16:47 Tom Warren
2012-06-07 16:02 ` Tom Warren
2012-06-08 19:36   ` Albert ARIBAUD
2012-06-08 19:41 ` Albert ARIBAUD
2012-06-08 21:44 ` Albert ARIBAUD
2012-06-08 22:00   ` Stephen Warren
2012-06-08 22:36     ` Stephen Warren
2012-06-08 22:52       ` Stephen Warren
2012-06-09  1:53         ` Simon Glass
2012-06-11 21:59           ` Stephen Warren
2012-06-10  8:22 ` Albert ARIBAUD
2012-05-03 15:56 Tom Warren
2012-05-04  7:30 ` Albert ARIBAUD
2012-05-04 15:36   ` Tom Warren
2012-04-26 21:14 Tom Warren
2012-03-28 21:48 Tom Warren
2012-03-29  6:13 ` Albert ARIBAUD
2012-03-09 22:39 Tom Warren
2012-03-10  8:25 ` Wolfgang Denk
2012-03-10 19:34   ` Simon Glass
2012-03-12 19:30     ` Tom Warren
2012-03-12 20:24       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831083237.3dd3419b@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox