[U-Boot] [PATCH 0/6] stdio: Clean up

Marek Vasut
2012-09-01T20:12:21Z

Dear Wolfgang Denk,

> Dear Marek Vasut,
>
> In message <201209011857.18390.marex@denx.de> you wrote:
> > I'd like to use it to track what's gonna end up in our patchdrop for the
> > university, hope it's not a problem.
>
> Please feel free to add a line to the commit message body, but please
> keep the Subject: clean.

OK

> > > You claim these patches are not ready yet, but they are not RFC
> > > either. What are they then?
> >
> > Something inbetween, still building. Yet, it does seem to be going well.
>
> If not clean, then it's RFC. Please mark as such when posting.

ARM just finished building, I'll have V2 for one of the patches, the rest seems
OK.

> > > > > 4) Besides the dead code removal - what exactly is the purpose of
> > > > >
> > > > > these patches?
> > > >
> > > > Mostly see 1).
> > >
> > > Then please document this in the commit message(s).
> >
> > Every patch has it's proper commit message (but 1/6, which is obvious).
>
> Hm... it didn't become clear to me...

Hm... I'll review and repost.

Yet, it still bothers me to see SPL grow by a few bytes. On the other hand,
uboot shrunk:

1316 Configuring for omap5_evm board...
1317 text data bss dec hex filename
1318 - 173007 4312 201912 379231 5c95f ./u-boot
1319 - 32046 1216 197508 230770 38572 ./spl/u-boot-spl
1320 + 172912 4300 201900 379112 5c8e8 ./u-boot
1321 + 32092 1216 197508 230816 385a0 ./spl/u-boot-spl

798 Configuring for da850evm - Board: da850evm, Options:
MAC_ADDR_IN_SPIFLASH
799 text data bss dec hex filename
800 - 153161 3476 54260 210897 337d1 ./u-boot
801 - 13867 1228 76 15171 3b43 ./spl/u-boot-spl
802 + 153046 3464 54252 210762 3374a ./u-boot
803 + 13907 1228 76 15211 3b6b ./spl/u-boot-spl

1280 Configuring for devkit8000 board...
1281 text data bss dec hex filename
1282 - 272855 7880 216436 497171 79613 ./u-boot
1283 - 42601 1840 198020 242461 3b31d ./spl/u-boot-spl
1284 + 272744 7868 216424 497036 7958c ./u-boot
1285 + 42647 1840 198020 242507 3b34b ./spl/u-boot-spl

etc.

> Best regards,
>
> Wolfgang Denk

Best regards,
Marek Vasut