[U-Boot] [PATCH 0/6] stdio: Clean up

Wolfgang Denk
2012-09-01T16:33:06Z

Dear Marek,

In message <201209011619.06260.marex@denx.de> you wrote:
>
> > > NOTE: I'm still working on the "compile tested on 2 different
> > > architectures"
...

> But all in all, I think exporting structures for others to access them as they
> wish isn't the best of ideas. Therefore I encapsulated these into the file and
> added accessors. The direction these patches take with STDIO and console.c stuff
> in U-Boot is such that applying proper encapsulation will allow easier
> conversion to the driver model stuff later. Yet I'm getting there with really
> small steps as I need to be very careful here.

Then please drop the "dm:" part from the commit messages.

> > 2) It appears this might be a RFC series, so why isn't it maked as
> > such in the Subject: ?
>
> It's not RFC, why would it be RFC? I'm still working on the "NOTE" part though.

Well, either a patch is ready for submitting (which includes being
compile-clean), or it is not - in which case it might still be good
enough as a RFC.

You claim these patches are not ready yet, but they are not RFC
either. What are they then?

> > 4) Besides the dead code removal - what exactly is the purpose of
> > these patches?
>
> Mostly see 1).

Then please document this in the commit message(s).

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
(1) Do it yourself.
(2) Hire someone to do it for you.
(3) Forbid your kids to do it.