From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] stdio: Clean up
Date: Sat, 1 Sep 2012 18:57:18 +0200 [thread overview]
Message-ID: <201209011857.18390.marex@denx.de> (raw)
In-Reply-To: <20120901163306.54394205617@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Marek,
>
> In message <201209011619.06260.marex@denx.de> you wrote:
> > > > NOTE: I'm still working on the "compile tested on 2 different
> > > > architectures"
>
> ...
>
> > But all in all, I think exporting structures for others to access them as
> > they wish isn't the best of ideas. Therefore I encapsulated these into
> > the file and added accessors. The direction these patches take with
> > STDIO and console.c stuff in U-Boot is such that applying proper
> > encapsulation will allow easier conversion to the driver model stuff
> > later. Yet I'm getting there with really small steps as I need to be
> > very careful here.
>
> Then please drop the "dm:" part from the commit messages.
I'd like to use it to track what's gonna end up in our patchdrop for the
university, hope it's not a problem.
> > > 2) It appears this might be a RFC series, so why isn't it maked as
> > >
> > > such in the Subject: ?
> >
> > It's not RFC, why would it be RFC? I'm still working on the "NOTE" part
> > though.
>
> Well, either a patch is ready for submitting (which includes being
> compile-clean), or it is not - in which case it might still be good
> enough as a RFC.
>
> You claim these patches are not ready yet, but they are not RFC
> either. What are they then?
Something inbetween, still building. Yet, it does seem to be going well.
> > > 4) Besides the dead code removal - what exactly is the purpose of
> > >
> > > these patches?
> >
> > Mostly see 1).
>
> Then please document this in the commit message(s).
Every patch has it's proper commit message (but 1/6, which is obvious).
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-01 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 22:44 [U-Boot] [PATCH 0/6] stdio: Clean up Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 1/6] stdio: dm: Remove dead code in console.c Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 2/6] stdio: dm: Add accessors to stdio_devices[] Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local Marek Vasut
2012-09-01 20:14 ` Marek Vasut
2012-09-01 23:11 ` Andreas Bießmann
2012-09-02 0:02 ` Marek Vasut
2012-09-02 8:12 ` Wolfgang Denk
2012-08-31 22:44 ` [U-Boot] [PATCH 4/6] stdio: dm: Add stdio_fd_to_name() call Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 5/6] stdio: dm: Use stdio_fd_to_name() call to localize stdio_names Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 6/6] stdio: dm: Optimize stdio_print_current_devices() Marek Vasut
2012-09-01 12:17 ` [U-Boot] [PATCH 0/6] stdio: Clean up Wolfgang Denk
2012-09-01 14:19 ` Marek Vasut
2012-09-01 16:33 ` Wolfgang Denk
2012-09-01 16:57 ` Marek Vasut [this message]
2012-09-01 20:00 ` Wolfgang Denk
2012-09-01 20:12 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209011857.18390.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox