From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] stdio: Clean up
Date: Sat, 1 Sep 2012 22:12:21 +0200 [thread overview]
Message-ID: <201209012212.21489.marex@denx.de> (raw)
In-Reply-To: <20120901200052.8A8D7205619@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Marek Vasut,
>
> In message <201209011857.18390.marex@denx.de> you wrote:
> > I'd like to use it to track what's gonna end up in our patchdrop for the
> > university, hope it's not a problem.
>
> Please feel free to add a line to the commit message body, but please
> keep the Subject: clean.
OK
> > > You claim these patches are not ready yet, but they are not RFC
> > > either. What are they then?
> >
> > Something inbetween, still building. Yet, it does seem to be going well.
>
> If not clean, then it's RFC. Please mark as such when posting.
ARM just finished building, I'll have V2 for one of the patches, the rest seems
OK.
> > > > > 4) Besides the dead code removal - what exactly is the purpose of
> > > > >
> > > > > these patches?
> > > >
> > > > Mostly see 1).
> > >
> > > Then please document this in the commit message(s).
> >
> > Every patch has it's proper commit message (but 1/6, which is obvious).
>
> Hm... it didn't become clear to me...
Hm... I'll review and repost.
Yet, it still bothers me to see SPL grow by a few bytes. On the other hand,
uboot shrunk:
1316 Configuring for omap5_evm board...
1317 text data bss dec hex filename
1318 - 173007 4312 201912 379231 5c95f ./u-boot
1319 - 32046 1216 197508 230770 38572 ./spl/u-boot-spl
1320 + 172912 4300 201900 379112 5c8e8 ./u-boot
1321 + 32092 1216 197508 230816 385a0 ./spl/u-boot-spl
798 Configuring for da850evm - Board: da850evm, Options:
MAC_ADDR_IN_SPIFLASH
799 text data bss dec hex filename
800 - 153161 3476 54260 210897 337d1 ./u-boot
801 - 13867 1228 76 15171 3b43 ./spl/u-boot-spl
802 + 153046 3464 54252 210762 3374a ./u-boot
803 + 13907 1228 76 15211 3b6b ./spl/u-boot-spl
1280 Configuring for devkit8000 board...
1281 text data bss dec hex filename
1282 - 272855 7880 216436 497171 79613 ./u-boot
1283 - 42601 1840 198020 242461 3b31d ./spl/u-boot-spl
1284 + 272744 7868 216424 497036 7958c ./u-boot
1285 + 42647 1840 198020 242507 3b34b ./spl/u-boot-spl
etc.
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-09-01 20:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 22:44 [U-Boot] [PATCH 0/6] stdio: Clean up Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 1/6] stdio: dm: Remove dead code in console.c Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 2/6] stdio: dm: Add accessors to stdio_devices[] Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 3/6] stdio: dm: Make stdio_devices[] local Marek Vasut
2012-09-01 20:14 ` Marek Vasut
2012-09-01 23:11 ` Andreas Bießmann
2012-09-02 0:02 ` Marek Vasut
2012-09-02 8:12 ` Wolfgang Denk
2012-08-31 22:44 ` [U-Boot] [PATCH 4/6] stdio: dm: Add stdio_fd_to_name() call Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 5/6] stdio: dm: Use stdio_fd_to_name() call to localize stdio_names Marek Vasut
2012-08-31 22:44 ` [U-Boot] [PATCH 6/6] stdio: dm: Optimize stdio_print_current_devices() Marek Vasut
2012-09-01 12:17 ` [U-Boot] [PATCH 0/6] stdio: Clean up Wolfgang Denk
2012-09-01 14:19 ` Marek Vasut
2012-09-01 16:33 ` Wolfgang Denk
2012-09-01 16:57 ` Marek Vasut
2012-09-01 20:00 ` Wolfgang Denk
2012-09-01 20:12 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209012212.21489.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox