public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug).
Date: Sun, 02 Sep 2012 19:03:48 +0200	[thread overview]
Message-ID: <20120902170348.AC011203B2F@gemini.denx.de> (raw)
In-Reply-To: <5037D648.1050808@ti.com>

Dear Tom Rini,

In message <5037D648.1050808@ti.com> you wrote:
> 
> And no need to not include command.h I think.  This makes it clear that
> a panic results in hang in SPL so that in the future, should someone
> depend on other behavior it's at least saying why we aren't resetting
> which is my concern.

I think a panic should always reset by default.  hang() is something
the user has explicitly ask for, it should not be used as the default
case.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We, the unwilling, led by the unknowing, are doing the impossible for
the ungrateful. We have done so much, for so long, with so little, we
are now qualified to do anything with nothing.

      reply	other threads:[~2012-09-02 17:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 20:37 [U-Boot] [PATCH 0/1] fix some SPL debug builds Jeroen Hofstee
2012-08-14 20:40 ` [U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug) Jeroen Hofstee
2012-08-15 17:11   ` Tom Rini
2012-08-17 10:51     ` Stefano Babic
2012-08-24 19:30   ` Tom Rini
2012-09-02 17:03     ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120902170348.AC011203B2F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox