public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] Loop block device for sandbox
Date: Mon, 3 Sep 2012 22:20:30 +0200	[thread overview]
Message-ID: <201209032220.31119.marex@denx.de> (raw)
In-Reply-To: <28659571.kCKYv4ylvR@bloomfield>

Dear Pavel Herrmann,

> On Monday 03 of September 2012 18:49:00 Marek Vasut wrote:
> > > +
> > > +static const char revision[] = "0.0";
> > > +static const char vendor[] = "SATA loopback";
> > > +
> > > +static const char * const filenames[] = CONFIG_SATA_LOOP_DISKS;
> > > +static int max_devs = CONFIG_SYS_SATA_MAX_DEVICE;
> > 
> > One more thing is missing -- documentation for these (add to doc/ ).
> 
> which file shoud that be exactly? README.sata has nothing about configs, i
> cannot find any README.sandbox or README.configs

Create one ... especially for the newly added feature -- eg. 
README.sata_loopback or something,

> > Alternatively (which would be much better), let sandbox uboot accept
> > params and supply these as params.
> 
> or even make a command that would allow you to specify a filename in
> runtime, possibly with a dynamic number of ports.

Good idea, indeed.

> Pavel Herrmann

Best regards,
Marek Vasut

  reply	other threads:[~2012-09-03 20:20 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29 15:46 [U-Boot] [PATCH] Loop block device for sandbox Pavel Herrmann
2012-08-29 15:48 ` Pavel Herrmann
2012-08-29 22:18 ` Marek Vasut
2012-08-30 17:14   ` Pavel Herrmann
2012-08-30 18:45     ` Marek Vasut
2012-08-30 19:07       ` Pavel Herrmann
2012-08-30 21:53         ` Marek Vasut
2012-08-31  9:09           ` Pavel Herrmann
2012-08-31 12:57             ` Marek Vasut
2012-08-31 14:25               ` Pavel Herrmann
2012-08-31 16:02                 ` Marek Vasut
2012-08-31 17:56                   ` Pavel Herrmann
2012-08-31 19:02                     ` Marek Vasut
2012-09-01 13:19 ` [U-Boot] [PATCH v2 1/2] " Pavel Herrmann
2012-09-01 13:19   ` [U-Boot] [PATCH 2/2] Use loop block device in sandbox board Pavel Herrmann
2012-09-01 14:20     ` Marek Vasut
2012-09-03 17:24       ` Pavel Herrmann
2012-09-03 17:23     ` [U-Boot] [PATCH v2 " Pavel Herrmann
2012-09-03 16:49   ` [U-Boot] [PATCH v2 1/2] Loop block device for sandbox Marek Vasut
2012-09-03 17:31     ` Pavel Herrmann
2012-09-03 20:20       ` Marek Vasut [this message]
2012-09-05 11:16   ` [U-Boot] [PATCH v3 " Pavel Herrmann
2012-09-05 11:16     ` [U-Boot] [PATCH v3 2/2] Use loop block device in sandbox board Pavel Herrmann
2012-09-05 11:33     ` [U-Boot] [PATCH v3 1/2] Loop block device for sandbox Marek Vasut
2012-09-05 12:38       ` Pavel Herrmann
2012-09-05 12:48         ` Marek Vasut
2012-09-05 20:25           ` Pavel Herrmann
2012-09-06  1:08             ` Marek Vasut
2012-09-06  8:45               ` Pavel Herrmann
2012-09-06  8:48                 ` Marek Vasut
2012-09-05 12:42       ` Pavel Herrmann
2012-09-05 12:52         ` Marek Vasut
2012-09-06 12:31     ` [U-Boot] [PATCH v4 " Pavel Herrmann
2012-09-06 23:29       ` Marek Vasut
2012-09-07  9:19         ` Pavel Herrmann
2012-09-07  9:26           ` Marek Vasut
2012-09-07  9:38             ` Pavel Herrmann
2012-09-07  9:42               ` Marek Vasut
2012-09-13 22:31           ` Tom Rini
2012-09-16 11:49             ` Pavel Herrmann
2012-09-16 11:58       ` [U-Boot] [PATCH v5 " Pavel Herrmann
2012-09-28  9:21         ` [U-Boot] [PATCH v6 " Pavel Herrmann
2012-09-28 18:22           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209032220.31119.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox