From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 3 Sep 2012 22:20:30 +0200
Subject: [U-Boot] [PATCH v2 1/2] Loop block device for sandbox
In-Reply-To: <28659571.kCKYv4ylvR@bloomfield>
References: <1346255203-1225-1-git-send-email-morpheus.ibis@gmail.com>
	<201209031849.00839.marex@denx.de> <28659571.kCKYv4ylvR@bloomfield>
Message-ID: <201209032220.31119.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Pavel Herrmann,

> On Monday 03 of September 2012 18:49:00 Marek Vasut wrote:
> > > +
> > > +static const char revision[] = "0.0";
> > > +static const char vendor[] = "SATA loopback";
> > > +
> > > +static const char * const filenames[] = CONFIG_SATA_LOOP_DISKS;
> > > +static int max_devs = CONFIG_SYS_SATA_MAX_DEVICE;
> > 
> > One more thing is missing -- documentation for these (add to doc/ ).
> 
> which file shoud that be exactly? README.sata has nothing about configs, i
> cannot find any README.sandbox or README.configs

Create one ... especially for the newly added feature -- eg. 
README.sata_loopback or something,

> > Alternatively (which would be much better), let sandbox uboot accept
> > params and supply these as params.
> 
> or even make a command that would allow you to specify a filename in
> runtime, possibly with a dynamic number of ports.

Good idea, indeed.

> Pavel Herrmann

Best regards,
Marek Vasut