[U-Boot] [PATCH v2 3/6] video: cfb_console: logo can be positioned via the splashpos variable

Anatolij Gustschin
2012-09-05T11:11:27Z

Hello Bastian,

On Wed, 5 Sep 2012 12:52:59 +0200
Bastian.Ruppert at sewerin.de wrote:
...
> > + video_logo_height += video_logo_ypos;
> > + return video_fb_address + video_logo_height * VIDEO_LINE_LEN;
> > + }
> > +#endif
>
> I have some trouble with this version when using splashpos = m,m .
> In this case video_logo_ypos is 32767 (BMP_ALIGN_CENTER) here.
> Following extension isworking for me:

Ah, indeed. Thanks for testing and catching it.

> #ifdef CONFIG_SPLASH_SCREEN_ALIGN
> /*
> * when using splashpos for video_logo, skip any info
> * output on video console if the logo is not at 0,0
> */
> if (video_logo_xpos || video_logo_ypos) {
> /*
> * video_logo_height is used in text and cursor offset
> * calculations. Since the console is below the logo,
> * we need to adjust the logo height
> */
> if (video_logo_ypos == BMP_ALIGN_CENTER)
> video_logo_height += max(0, (VIDEO_VISIBLE_ROWS - \
> VIDEO_LOGO_HEIGHT) /
> 2);
> else if (video_logo_ypos >= 0)
> video_logo_height += video_logo_ypos;

OK. But please use

else if (video_logo_ypos > 0)
video_logo_height += video_logo_ypos;

...
> Should i post a version 3 for this patch?

Yes, please.

Thanks,

Anatolij