public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] Commit 67cbbf2... breaks some ARM builds
@ 2012-09-06  7:49 Albert ARIBAUD
  0 siblings, 0 replies; only message in thread
From: Albert ARIBAUD @ 2012-09-06  7:49 UTC (permalink / raw)
  To: u-boot

Hello,

While merging u-boot/master and u-boot-arm/master in preparation of a
pull requst, I saw that commit 67cbbf2... ("mmc: Remove unused item
flags in struct mmc_cmd") breaks several arm builds such as palmld:

$ LANG=C ./MAKEALL palmld
Configuring for palmld board...
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make: *** [drivers/mmc/libmmc.o] Error 2
arm-linux-gnueabi-size: './u-boot': No such file
pxa_mmc_gen.c: In function 'pxa_mmc_start_cmd':
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c: In function 'pxa_mmc_cmd_done':
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers/mmc/libmmc.o] Error 2
make: *** Waiting for unfinished jobs....

--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with errors: 1 ( palmld )
----------------------------------------------------------

Apparently, either the commit overlooked some ARM boards when
considering 'flags' were unused, or it did not remove all references to
flags throughout the code base.

Kapster, can you post a fix or revert?

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-09-06  7:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-06  7:49 [U-Boot] Commit 67cbbf2... breaks some ARM builds Albert ARIBAUD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox