From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 11 Sep 2012 08:54:40 +0200
Subject: [U-Boot] [PATCHv2] ARM: Add Altera SOCFPGA Cyclone5
In-Reply-To: <20120911002123.GB6149@elf.ucw.cz>
References: <1346456341-13759-1-git-send-email-dinguyen@altera.com>
	<201209010047.15704.marex@denx.de>
	<20120911002123.GB6149@elf.ucw.cz>
Message-ID: <201209110854.40266.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Pavel Machek,

> Hi!
> 
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > > 
> > > Add minimal support for Altera's SOCFPGA Cyclone 5 hardware.
> > > 
> > > Applied on top of trini/WIP/spl-improvements v6
> > 
> > [...]
> > 
> > __noreturn attribute to reset_cpu() is still missing, but that's a
> > minor thing.
> 
> Plus, I guess these should be deleted. We already have prototype in
> common....
> 
> arch/arm/include/asm/arch-kirkwood/cpu.h:void reset_cpu(unsigned long
> ignored); arch/arm/include/asm/arch-orion5x/cpu.h:void reset_cpu(unsigned
> long ignored); arch/arm/include/asm/arch-socfpga/reset_manager.h:void
> reset_cpu(ulong addr);

Agreed.

> What needs to be done to get the socfpga patches merged?

I'd say, sacrifice a chicken :-) The patches look quite fine :-)

> 									Pavel

Best regards,
Marek Vasut