From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 13 Sep 2012 01:45:07 +0200
Subject: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver
In-Reply-To: <505117D3.1070303@inov.pt>
References: <1347448523-19565-1-git-send-email-jose.goncalves@inov.pt>
	<201209122311.16702.marex@denx.de> <505117D3.1070303@inov.pt>
Message-ID: <201209130145.08012.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Jos? Miguel Gon?alves,

> Hi Marek,
> 
> On 09/12/2012 10:11 PM, Marek Vasut wrote:
> > Dear Jos? Miguel Gon?alves,
> > 
> >> +
> >> +/*
> >> + * Hardware specific access to control-lines function
> >> + */
> >> +static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned
> >> int ctrl) +{
> >> +	s3c24xx_nand *const nand = s3c24xx_get_base_nand();
> >> +	struct nand_chip *this = mtd->priv;
> >> +
> >> +	if (ctrl & NAND_CTRL_CHANGE) {
> >> +		if (ctrl & NAND_CLE)
> >> +			this->IO_ADDR_W = (void __iomem *)&nand->nfcmmd;
> >> +		else if (ctrl & NAND_ALE)
> >> +			this->IO_ADDR_W = (void __iomem *)&nand->nfaddr;
> >> +		else
> >> +			this->IO_ADDR_W = (void __iomem *)&nand->nfdata;
> > 
> > Do you need this cast ?
> 
> Without it gcc gives me a warning:
> 
> s3c24xx_nand.c:90:20: warning: assignment discards `volatile' qualifier
> from pointer target type [enabled by default]

Not that you need to do the assignment into the structure .... use local 
variable, no ?

> > +/*
> > + * Board-specific NAND initialization.
> > + */
> > +int board_nand_init(struct nand_chip *nand)
> > +{
> > +	static int chip_n = 0;
> > +	s3c24xx_nand *const nand_reg = s3c24xx_get_base_nand();
> > +	u_long nfconf, nfcont;
> > +
> > +	if (chip_n == 0) {
> > +		/* Extend NAND timings to the maximum */
> > +		nfconf = readl(&nand_reg->nfconf);
> > +		nfconf |= 0x7770;
> > Magic
> > 
> >> +		writel(nfconf, &nand_reg->nfconf);
> >> +
> >> +		/* Disable chip selects and soft lock, enable controller */
> >> +		nfcont = readl(&nand_reg->nfcont);
> >> +		nfcont &= ~NFCONT_WP;
> >> +		nfcont |= NFCONT_NCE1 | NFCONT_NCE0 | NFCONT_ENABLE;
> >> +		writel(nfcont, &nand_reg->nfcont);
> > 
> > use clrsetbits_le32()
> 
> I will do that and also define some macros for the magic values.
> 
> Regards,
> Jos? Gon?alves

Best regards,
Marek Vasut